Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-1943 - Add integration tests with Infinispan #243

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

cristianonicolai
Copy link
Contributor

No description provided.

@jstastny-cz
Copy link

I thought we're sticking to testcontainers for running the docker containers. The docker-maven-plugin seems to have the same limitation[1] that testcontainers do [2] - supports docker only.

One of the arguments against mavenized docker container startup was that when using testcontainers it's plain Java - the tests can be run from IDE out of the box.

[1] fabric8io/docker-maven-plugin#1330
[2] testcontainers/testcontainers-java#2088

@cristianonicolai cristianonicolai force-pushed the persistence branch 4 times, most recently from 0dfdcc3 to 6862401 Compare April 23, 2020 08:52
@cristianonicolai
Copy link
Contributor Author

@jstastny-cz reviewed tests

Copy link

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment regarding spring boot port handling.

@cristianonicolai cristianonicolai merged commit cd880e7 into apache:master Apr 28, 2020
@cristianonicolai cristianonicolai deleted the persistence branch April 28, 2020 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants