[incubator-kie-drools-6016] Emit a warning when an eval is improperly… #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and unnecessarily used
tkobayas
commented
Jul 12, 2024
Comment on lines
+234
to
+241
| public static void logWarnIfImproperEval(EvalCondition evalCondition, String evalExpression) { | ||
| if (warnLogCounter == 10) { | ||
| warnLogCounter++; | ||
| LOG.warn("More eval warnings will be suppressed..."); | ||
| return; | ||
| } else if (warnLogCounter > 10) { | ||
| return; // avoid flooding the logs | ||
| } |
There was a problem hiding this comment.
Log a maximum of 10 warnings, because I guess if a user likes to use eval, there would be tons of warnings. 10 logs would be enough to get attention.
tkobayas
commented
Jul 16, 2024
Comment on lines
+248
to
+257
| for (Declaration declaration : evalCondition.getRequiredDeclarations()) { | ||
| if (declaration.getPattern() != null) { | ||
| sb.append("'"); | ||
| sb.append(declaration.getIdentifier()); | ||
| sb.append("' comes from previous pattern '"); | ||
| String className = declaration.getPattern().getObjectType().getClassName(); | ||
| sb.append(className.substring(className.lastIndexOf('.') + 1)); | ||
| sb.append("'. "); | ||
| } | ||
| } |
There was a problem hiding this comment.
The criteria of the warning is "If the eval uses a declaration which comes from previous pattern". I guess, most of eval usages meet the case. Do you think of other criteria? @mariofusco
There was a problem hiding this comment.
No, this is also what I had in mind. I cannot think to any other condition at the moment.
There was a problem hiding this comment.
Thanks, I'll go with it.
mariofusco
approved these changes
Jul 16, 2024
baldimir
approved these changes
Jul 29, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Aug 6, 2024
… and unnecessarily used (apache#6024)
rodrigonull
pushed a commit
to rodrigonull/incubator-kie-drools
that referenced
this pull request
Oct 7, 2024
… and unnecessarily used (apache#6024)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and unnecessarily used
Issue: