Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-6638 DMN OAS generation NPE #3870

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Oct 2, 2021

fix NPE bug as described in:

JIRA: https://issues.redhat.com/browse/DROOLS-6638

referenced Pull Requests: none

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@tarilabs
Copy link
Member Author

tarilabs commented Oct 4, 2021

Jenkins retest this

@tarilabs
Copy link
Member Author

tarilabs commented Oct 4, 2021

jenkins run cdb

@tarilabs tarilabs requested review from pibizza and hellowdan October 4, 2021 07:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tarilabs
Copy link
Member Author

tarilabs commented Oct 4, 2021

cdb failure unrelated

09:29:27  [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project optaplanner-core: Compilation failure: Compilation failure: 
09:29:27  [ERROR] /home/jenkins/workspace/KIE/main/compile/drools-main.compile/bc/kiegroup_optaplanner/optaplanner-core/src/main/java/org/optaplanner/core/config/domain/ReflectionsKieVfsUrlType.java:[83,39] cannot find symbol
09:29:27  [ERROR]   symbol:   method toPortableString()
09:29:27  [ERROR]   location: class org.kie.memorycompiler.resources.KiePath
09:29:27  [ERROR] /home/jenkins/workspace/KIE/main/compile/drools-main.compile/bc/kiegroup_optaplanner/optaplanner-core/src/main/java/org/optaplanner/core/config/domain/ReflectionsKieVfsUrlType.java:[136,37] cannot find symbol
09:29:27  [ERROR]   symbol:   method toPortableString()
09:29:27  [ERROR]   location: class org.kie.memorycompiler.resources.KiePath
09:29:27  [ERROR] -> [Help 1]
09:29:27  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project optaplanner-core: Compilation failure

Copy link
Contributor

@pibizza pibizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on remote resources.

@danielezonca danielezonca merged commit 50f9d7c into apache:main Oct 4, 2021
tarilabs added a commit to tarilabs/drools that referenced this pull request Oct 4, 2021
* DROOLS-6638 reproducer

* fix (wrong loop nesting)
danielezonca pushed a commit that referenced this pull request Oct 5, 2021
* DROOLS-6638 reproducer

* fix (wrong loop nesting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants