-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cross-close the underlying rocksdb session pool #598
Conversation
private final AtomicInteger refCount; | ||
|
||
public RocksDBStdSessions(HugeConfig config, String database, String store, | ||
String dataPath,String walPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an empty between args
this.rocksdb = origin.rocksdb; | ||
this.sstFileManager = origin.sstFileManager; | ||
this.cfs = origin.cfs; | ||
this.refCount = origin.refCount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.refCount = origin.refCount.incrementAndGet();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have to share the address of refCount
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
============================================
+ Coverage 70.46% 71.11% +0.65%
- Complexity 3458 3497 +39
============================================
Files 216 216
Lines 16612 16637 +25
Branches 2367 2370 +3
============================================
+ Hits 11705 11831 +126
+ Misses 3658 3558 -100
+ Partials 1249 1248 -1
Continue to review full report at Codecov.
|
af5167f
to
3d7fe38
Compare
fix: #597 Change-Id: I8b185cd7f81a9a04bc6fd971490ae887fd4ddbb5
Change-Id: I151e112cb2e220d4a7b20da3e08b50d5f904516b
Change-Id: Idea99c81aeff21aa8f3d36ada6df240995a47023
3d7fe38
to
c120381
Compare
fix: #597
Change-Id: I8b185cd7f81a9a04bc6fd971490ae887fd4ddbb5