-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve exception type if failed while waiting for async task #596
Conversation
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
============================================
+ Coverage 66.93% 70.44% +3.51%
- Complexity 3332 3458 +126
============================================
Files 216 216
Lines 16605 16612 +7
Branches 2366 2367 +1
============================================
+ Hits 11114 11702 +588
+ Misses 4299 3661 -638
- Partials 1192 1249 +57
Continue to review full report at Codecov.
|
throw (RuntimeException) cause; | ||
} | ||
throw new HugeException("Async task failed with error: %s", | ||
cause.getMessage(), cause); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'cause' is exception arg, 'cause.getMessage()' is message arg, so change order of them.
throw new HugeException("Async task failed with error: %s",
cause, cause.getMessage());
} catch (Exception e) { | ||
throw new HugeException("Async task failed", e); | ||
throw new HugeException("Async task failed with error: %s", | ||
e.getMessage(), e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Change-Id: Ifab67a27bc294618bee769f8d22540ab01905111
The job exceeded the maximum log length, and has been terminated Change-Id: I9ad883a5bbb68c69d13554fc58964bae23339575
Change-Id: I4d829c070d2bf324e3ccb3a7a79d59ed548acc95
667bc2e
to
1ff4c86
Compare
Change-Id: Ifab67a27bc294618bee769f8d22540ab01905111