-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining count error when query edge in page #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I07920cb7de15a837cfad1f0a130fc6d036e4d3bd
javeme
requested changes
May 16, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinaryEntryIterator.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
============================================
+ Coverage 69.01% 69.36% +0.35%
- Complexity 3283 3344 +61
============================================
Files 208 216 +8
Lines 16193 16450 +257
Branches 2334 2352 +18
============================================
+ Hits 11175 11410 +235
- Misses 3766 3781 +15
- Partials 1252 1259 +7
Continue to review full report at Codecov.
|
javeme
requested changes
May 16, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/page/QueryList.java
Outdated
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlTable.java
Outdated
Show resolved
Hide resolved
Change-Id: I03f15a4cbd01bfa6967a191571bdc381df29bd1a
javeme
approved these changes
May 22, 2019
javeme
requested changes
May 22, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/page/PageState.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/page/PageInfo.java
Outdated
Show resolved
Hide resolved
Change-Id: I57c696c1b19162414d3c18f1b81dc6cf05d6b506
Change-Id: I1c4130db46b8828a1b76a0cfd23cf624abd7ad38
javeme
approved these changes
May 22, 2019
zhoney
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I07920cb7de15a837cfad1f0a130fc6d036e4d3bd