Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scylladb backend doesn't support label query in page #455

Merged
merged 4 commits into from
Apr 16, 2019

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Apr 15, 2019

fix: Caused by: com.datastax.driver.core.exceptions.PagingStateException: Paging state mismatch, this means that either the paging state contents were altered, or you're trying to apply it to a different statement

Change-Id: I579a49cdbd586a60dbfbe2a508dafc0f8e66e8fa

@Linary Linary force-pushed the scylladb-label-page branch from 6c1d263 to c5eaf17 Compare April 15, 2019 07:46
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #455 into master will decrease coverage by 1.18%.
The diff coverage is 89.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #455      +/-   ##
===========================================
- Coverage     70.18%     69%   -1.19%     
+ Complexity     3286    3274      -12     
===========================================
  Files           208     208              
  Lines         16097   16146      +49     
  Branches       2314    2321       +7     
===========================================
- Hits          11298   11141     -157     
- Misses         3544    3759     +215     
+ Partials       1255    1246       -9
Impacted Files Coverage Δ Complexity Δ
.../baidu/hugegraph/backend/tx/SchemaTransaction.java 84.04% <0%> (-1.83%) 60 <0> (ø)
...ackend/store/cassandra/CassandraStoreProvider.java 100% <100%> (ø) 6 <1> (ø) ⬇️
.../backend/store/scylladb/ScyllaDBStoreProvider.java 100% <100%> (+14.28%) 7 <0> (ø) ⬇️
...graph/backend/store/cassandra/CassandraTables.java 86.36% <91.66%> (-1.55%) 1 <0> (ø)
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 90.09% <93.54%> (+90.09%) 10 <6> (+10) ⬆️
...gegraph/backend/store/scylladb/ScyllaDBTables.java 0% <0%> (-78.23%) 0% <0%> (-13%)
...in/java/com/baidu/hugegraph/backend/id/EdgeId.java 75% <0%> (-13.89%) 29% <0%> (-3%)
.../hugegraph/backend/store/BackendEntryIterator.java 59.25% <0%> (-7.41%) 14% <0%> (ø)
...va/com/baidu/hugegraph/type/define/Directions.java 50% <0%> (-5.56%) 9% <0%> (-2%)
...raph/backend/store/rocksdb/RocksDBStdSessions.java 69.23% <0%> (-2.47%) 23% <0%> (-2%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eaef03...bd4dbcf. Read the comment docs.

Linary added 2 commits April 15, 2019 20:11
Change-Id: I579a49cdbd586a60dbfbe2a508dafc0f8e66e8fa

Use version <= 20 exist bug: "Paging state mismatch, this means that either the paging state contents were altered, or you're trying to apply it to a different statement"
Change-Id: Ib413d55ee592e0dfccd907e14934fcb8bec036a3
@Linary Linary force-pushed the scylladb-label-page branch from c5eaf17 to 1d4ed65 Compare April 15, 2019 12:12
Change-Id: I3b918556fbeb71d86fd418d2a7f4d83c57acf9a3
javeme
javeme previously approved these changes Apr 16, 2019
Change-Id: Ia0db2edf03588260ea231124c322b9fecb0218c8
@zhoney zhoney merged commit 802ffb1 into master Apr 16, 2019
@zhoney zhoney deleted the scylladb-label-page branch April 16, 2019 12:11
javeme added a commit that referenced this pull request Oct 24, 2019
Change-Id: I1978174e2fbf0ddb64e3d3bdee1a747216fc038f
related: #455
zhoney pushed a commit that referenced this pull request Oct 25, 2019
related: #455

Change-Id: I1978174e2fbf0ddb64e3d3bdee1a747216fc038f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants