-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scylladb backend doesn't support label query in page #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linary
force-pushed
the
scylladb-label-page
branch
from
April 15, 2019 07:46
6c1d263
to
c5eaf17
Compare
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
===========================================
- Coverage 70.18% 69% -1.19%
+ Complexity 3286 3274 -12
===========================================
Files 208 208
Lines 16097 16146 +49
Branches 2314 2321 +7
===========================================
- Hits 11298 11141 -157
- Misses 3544 3759 +215
+ Partials 1255 1246 -9
Continue to review full report at Codecov.
|
javeme
requested changes
Apr 15, 2019
...sandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraStoreProvider.java
Outdated
Show resolved
Hide resolved
...scylladb/src/main/java/com/baidu/hugegraph/backend/store/scylladb/ScyllaDBStoreProvider.java
Outdated
Show resolved
Hide resolved
Change-Id: I579a49cdbd586a60dbfbe2a508dafc0f8e66e8fa Use version <= 20 exist bug: "Paging state mismatch, this means that either the paging state contents were altered, or you're trying to apply it to a different statement"
Change-Id: Ib413d55ee592e0dfccd907e14934fcb8bec036a3
Linary
force-pushed
the
scylladb-label-page
branch
from
April 15, 2019 12:12
c5eaf17
to
1d4ed65
Compare
javeme
requested changes
Apr 15, 2019
...sandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraStoreProvider.java
Outdated
Show resolved
Hide resolved
Change-Id: I3b918556fbeb71d86fd418d2a7f4d83c57acf9a3
javeme
previously approved these changes
Apr 16, 2019
zhoney
requested changes
Apr 16, 2019
...sandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraStoreProvider.java
Outdated
Show resolved
Hide resolved
...scylladb/src/main/java/com/baidu/hugegraph/backend/store/scylladb/ScyllaDBStoreProvider.java
Outdated
Show resolved
Hide resolved
Change-Id: Ia0db2edf03588260ea231124c322b9fecb0218c8
javeme
approved these changes
Apr 16, 2019
zhoney
approved these changes
Apr 16, 2019
javeme
added a commit
that referenced
this pull request
Oct 24, 2019
Change-Id: I1978174e2fbf0ddb64e3d3bdee1a747216fc038f related: #455
zhoney
pushed a commit
that referenced
this pull request
Oct 25, 2019
related: #455 Change-Id: I1978174e2fbf0ddb64e3d3bdee1a747216fc038f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Caused by: com.datastax.driver.core.exceptions.PagingStateException: Paging state mismatch, this means that either the paging state contents were altered, or you're trying to apply it to a different statement
Change-Id: I579a49cdbd586a60dbfbe2a508dafc0f8e66e8fa