Limit the name of the gremlin request less than 256 bytes #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
previously requested changes
Jan 3, 2019
hugegraph-api/src/main/java/com/baidu/hugegraph/api/job/GremlinAPI.java
Outdated
Show resolved
Hide resolved
javeme
requested changes
Jan 4, 2019
hugegraph-api/src/main/java/com/baidu/hugegraph/api/job/GremlinAPI.java
Outdated
Show resolved
Hide resolved
| byte[] srcBytes = firstLine.getBytes(CHARSET); | ||
| if (srcBytes.length > MAX_NAME_LENGTH) { | ||
| byte[] dstBytes = new byte[MAX_NAME_LENGTH]; | ||
| System.arraycopy(srcBytes, 0, dstBytes, 0, MAX_NAME_LENGTH); |
There was a problem hiding this comment.
may cause encoding exception if the end byte is truncated
see: decoder.onMalformedInput(CodingErrorAction.IGNORE);
javeme
requested changes
Jan 7, 2019
| } else { | ||
| return firstLine; | ||
| } | ||
| } catch (CharacterCodingException e) { |
Change-Id: I46ccdffd92087b50676e1612226424208f66dbee
zhoney
approved these changes
Jan 7, 2019
javeme
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I46ccdffd92087b50676e1612226424208f66dbee