Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dist): fix the JSON license issue #2697

Merged
merged 4 commits into from
Nov 25, 2024
Merged

chore(dist): fix the JSON license issue #2697

merged 4 commits into from
Nov 25, 2024

Conversation

VGalaxies
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.94%. Comparing base (3ab8b28) to head (7138bf7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2697   +/-   ##
=========================================
  Coverage     46.94%   46.94%           
  Complexity      821      821           
=========================================
  Files           745      745           
  Lines         60062    60062           
  Branches       7670     7670           
=========================================
  Hits          28195    28195           
- Misses        29042    29045    +3     
+ Partials       2825     2822    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 23, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 23, 2024
@VGalaxies VGalaxies changed the title chore(dist): fix some license issues chore(dist): fix the JSON license issue Nov 23, 2024
imbajin
imbajin previously approved these changes Nov 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 25, 2024
@imbajin imbajin requested a review from simon824 November 25, 2024 07:06
@imbajin
Copy link
Member

imbajin commented Nov 25, 2024

wait for #2698 merged

@imbajin
Copy link
Member

imbajin commented Nov 25, 2024

Also note the dependency should use test scope?

Seems only used in hugegraph-pd/hg-pd-test/src/main/java/org/apache/hugegraph/pd/rest/RestApiTest.java

@simon824 simon824 merged commit f0b1395 into master Nov 25, 2024
18 of 19 checks passed
@simon824 simon824 deleted the fix-license branch November 25, 2024 09:20
VGalaxies added a commit that referenced this pull request Nov 26, 2024
* setup

* chore: change json scope to 'test' in pd.pom

* update license

---------

Co-authored-by: imbajin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants