chore(commons): migrate hugegraph-commons #2628

VGalaxies · 2024-08-10T04:17:25Z

TODO:
After this PR merged, change the README in commons & pin a issue to notify all users/devs to know the context (also update the repo description...)

Finally, we may need start a discussion for marking commons repo in achieved status

Refer:

Change-Id: Icc8f9121d56679b266459125afc33180d8b568bf

…itory Change-Id: I198cd1e8a7d34a85d08b93261f33f07bb29335c9

Change-Id: I16d328738ead94efcad9d82bb8f27be2c4ca84a9

Change-Id: I04cc0107aec90440ee2ae8c5c6add8a7c787f4f4

Change-Id: I8cfd2dce48e2901af4773ea0c8d867edd6d21562

Change-Id: I7fd0d4ee3b6957878ed2850dd389dd78f42de71e

Change-Id: I655bdf4da20e0c6b6d7796958485ab066f0020f1

Change-Id: I8e123a315e483ed66658ce93c3eaffa61d94cfb3

Change-Id: I625be2f4691a7821dbf3107d0f28ce079d46dfee

Add lockManager for mutual exclusion of thread in long time operation. Change-Id: I155e2b6bb6fffe88e4965c85d8ff68f9c49d04be

Change-Id: I471a115fca5c84f8f25c7026fe834be305ab39b6

Change-Id: I745465ef6f3942f1e6774bacc1e59a1e5a0b200e

Add lockManager for mutual exclusion of thread in long time operation. Change-Id: I155e2b6bb6fffe88e4985c85d8ff68f9c49d04be

Change-Id: Ic5298b36ecf68f3a2b87b35bd793953e6505a9ae Signed-off-by: Liu Jie <[email protected]>

Change-Id: I36c123eb7dfb101f99a176fcd9b2ee1f0f0211d7 Signed-off-by: Liu Jie <[email protected]>

Change-Id: I5f4d4d5c823ea4e14a135b59fb2384299686b4d5 Signed-off-by: Liu Jie <[email protected]>

…bility. Change-Id: Ib36dc135241f77c99d39d458ee144dbe888c541b Signed-off-by: Liu Jie <[email protected]>

Change-Id: Idedff1ca762cd56f171152174bdbfb0bef4b8d4f

Change-Id: Idce80465ea4cbe92ac836bbc8d293e77ad7c7c5c

trivial grammar change. Change-Id: Ice29a709b9a5b5d7f2f7838d79541f63cf00a0c5

Change-Id: If0bfaf91c45eac055e3f851b7f1dd5647d58d175

add read write lock support Change-Id: Ic339f5d81c9f475ee11ada38167fe42169c10971

Change-Id: I569d82397408fb255d8ad9653e8b561ba1a60c1e

Change-Id: I2fd816ba13978d3d4cf2cb7a9724fe2d5f29a010

Change-Id: I19ea584802edd469d503b9fb57f630bf0c660487 Signed-off-by: Liu Jie <[email protected]>

Change-Id: Iadae3837c2e9e0fddadbebbee097000c281e267c Signed-off-by: Liu Jie <[email protected]>

Change-Id: I57305dd209416620758b5bf183e791f8734af711

Change-Id: I55a359b799119c04ea0e89d013f1c034453c2ba4

…CommonVersion Change-Id: I5bcd766bb3435de98833759efcba5d3fa0650499

… more meaningfull Change-Id: I4505c1335bfc6eeb03658597f6f6ae5e994a2cf2 Signed-off-by: Liu Jie <[email protected]>

…mons-v2

codecov · 2024-08-10T04:40:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.18%. Comparing base (dc3070f) to head (b087f08).
Report is 231 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2628      +/-   ##
============================================
- Coverage     47.22%   47.18%   -0.04%     
  Complexity      583      583              
============================================
  Files           718      718              
  Lines         58441    58465      +24     
  Branches       7492     7495       +3     
============================================
- Hits          27598    27589       -9     
- Misses        28065    28090      +25     
- Partials       2778     2786       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

javeme · 2024-08-10T10:13:50Z

Is hugegraph-commons still releasing versions frequently? we need to merge it into hugegraph repo only if yes.

.asf.yaml

imbajin · 2024-08-10T10:15:33Z

.asf.yaml

@@ -41,7 +41,8 @@ github:
          - Analyze (java)
          - CodeQL
          - check-license
-          - build (memory, 11)
+          - build (memory, 11)  # Server CI
+          - build (11)          # Commons CI


maybe we need ensure it in fork repo to prevent dead-lock (after merge it)

imbajin · 2024-08-10T10:38:27Z

.github/workflows/commons-ci.yml

@@ -36,19 +39,23 @@ jobs:
        with:
          fetch-depth: 2

-      - name: License check(RAT)
+      - name: Use staged maven repo settings
+        if: ${{ env.USE_STAGE == 'true' }}


we need visit stage here?

commons-rpc depends on commons-common, which currently only exists in the maven stage repository

TODO: reset use stage to false later

.github/workflows/commons-ci.yml

VGalaxies · 2024-08-18T04:12:07Z

After changing the asf file from build (memory, 11) to build-server (memory, 11), if the GitHub workflow file is also modified in this PR, it will prevent build (memory, 11) from running (required). Therefore, only the asf file is modified in this PR, with a follow-up PR to change the GitHub workflow file from build to build-server (also disable merge button). cc @imbajin

imbajin · 2024-08-22T03:29:19Z

Remember this PR must use Merge (can't use rebase option)

Linary and others added 30 commits August 9, 2018 09:52

HugeGraph-341: First commit hugegraph-common code

a5fa901

Change-Id: Icc8f9121d56679b266459125afc33180d8b568bf

HugeGraph-344: add distributionManagement to deploy baidu maven repos…

5f30552

…itory Change-Id: I198cd1e8a7d34a85d08b93261f33f07bb29335c9

HugeGraph-351: code format and clean up some warnings

3e5f626

Change-Id: I16d328738ead94efcad9d82bb8f27be2c4ca84a9

HugeGraph-351: fixed bug that CoreOption constructor has been removed

db55e23

Change-Id: I04cc0107aec90440ee2ae8c5c6add8a7c787f4f4

HugeGraph-357: modify return type of TriFunction

cccef5d

Change-Id: I8cfd2dce48e2901af4773ea0c8d867edd6d21562

HugeGraph-326: add slf4j-api that has been mistakenly deleted

5603b9c

Change-Id: I7fd0d4ee3b6957878ed2850dd389dd78f42de71e

HugeGraph-407: add KeyLock class

7bdf878

Change-Id: I655bdf4da20e0c6b6d7796958485ab066f0020f1

HugeGraph-410: fixed code style of hugegraph-common

3695904

Change-Id: I8e123a315e483ed66658ce93c3eaffa61d94cfb3

HugeGraph-254: improve utils class perf with final(inline)

d592690

Change-Id: I625be2f4691a7821dbf3107d0f28ce079d46dfee

HugeGraph-369

ec2599d

Add lockManager for mutual exclusion of thread in long time operation. Change-Id: I155e2b6bb6fffe88e4965c85d8ff68f9c49d04be

HugeGraph-462: add event manager

e88f54a

Change-Id: I471a115fca5c84f8f25c7026fe834be305ab39b6

HugeGraph-476: add destroy() method

9cc9cad

Change-Id: I745465ef6f3942f1e6774bacc1e59a1e5a0b200e

HugeGraph-487

9a1417f

Add lockManager for mutual exclusion of thread in long time operation. Change-Id: I155e2b6bb6fffe88e4985c85d8ff68f9c49d04be

HugeGraph-494: refine logic of lock() menthod

171e723

Change-Id: Ic5298b36ecf68f3a2b87b35bd793953e6505a9ae Signed-off-by: Liu Jie <[email protected]>

HugeGrap-499: fix english grammer in lock

9778a8b

Change-Id: I36c123eb7dfb101f99a176fcd9b2ee1f0f0211d7 Signed-off-by: Liu Jie <[email protected]>

Always define long variable endwith 'L' indicator.

d3960c1

Change-Id: I5f4d4d5c823ea4e14a135b59fb2384299686b4d5 Signed-off-by: Liu Jie <[email protected]>

HugeGraph-503: using bit shift whenever, if not affect the code reada…

315000a

…bility. Change-Id: Ib36dc135241f77c99d39d458ee144dbe888c541b Signed-off-by: Liu Jie <[email protected]>

HugeGraph-501: fix EventHub ConcurrentModificationException

0c58069

Change-Id: Idedff1ca762cd56f171152174bdbfb0bef4b8d4f

HugeGraph-410: improve code style

5252a7e

Change-Id: Idce80465ea4cbe92ac836bbc8d293e77ad7c7c5c

hugegraph-499

9faea02

trivial grammar change. Change-Id: Ice29a709b9a5b5d7f2f7838d79541f63cf00a0c5

HugeGraph-482: upgrade log4j to log4j2

e05d130

Change-Id: If0bfaf91c45eac055e3f851b7f1dd5647d58d175

hugegraph-502

6052985

add read write lock support Change-Id: Ic339f5d81c9f475ee11ada38167fe42169c10971

HugeGraph-527: add customized implemention version to manifest.mf

b76e0ea

Change-Id: I569d82397408fb255d8ad9653e8b561ba1a60c1e

HugeGraph-527: First add the version to the common module.

dfd3190

Change-Id: I2fd816ba13978d3d4cf2cb7a9724fe2d5f29a010

HugeGraph-531: Fix typo at OptionHolder class

dec8fe9

Change-Id: I19ea584802edd469d503b9fb57f630bf0c660487 Signed-off-by: Liu Jie <[email protected]>

HugeGraph-532: Rewrite checksocket class

f33c093

Change-Id: Iadae3837c2e9e0fddadbebbee097000c281e267c Signed-off-by: Liu Jie <[email protected]>

HugeGraph-525: add vertion check util

5cda854

Change-Id: I57305dd209416620758b5bf183e791f8734af711

HugeGraph-131: clean up some warnings in LockGroup

a200dea

Change-Id: I55a359b799119c04ea0e89d013f1c034453c2ba4

HugeGraph-525: add the const NAME of component hugegraph-common into …

8bdac2c

…CommonVersion Change-Id: I5bcd766bb3435de98833759efcba5d3fa0650499

HugeGraph-547: replace tilNextMillis by tillNextMills as the later is…

f6cdc8a

… more meaningfull Change-Id: I4505c1335bfc6eeb03658597f6f6ae5e994a2cf2 Signed-off-by: Liu Jie <[email protected]>

Merge remote-tracking branch 'commons/migrate-commons' into intro-com…

459d441

…mons-v2

javeme reviewed Aug 10, 2024

View reviewed changes

.asf.yaml Outdated Show resolved Hide resolved

VGalaxies force-pushed the intro-commons-v2 branch 2 times, most recently from eb52c1c to 8579f7d Compare August 10, 2024 10:36

imbajin reviewed Aug 10, 2024

View reviewed changes

javeme reviewed Aug 10, 2024

View reviewed changes

.github/workflows/commons-ci.yml Outdated Show resolved Hide resolved

VGalaxies force-pushed the intro-commons-v2 branch 2 times, most recently from a4e1fd3 to 0b2376e Compare August 18, 2024 04:05

VGalaxies marked this pull request as ready for review August 20, 2024 10:25

dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. ci-cd Build or deploy feature New feature labels Aug 20, 2024

VGalaxies mentioned this pull request Aug 20, 2024

feat(common): add a tool method encode apache/incubator-hugegraph-commons#146

Merged

VGalaxies requested a review from imbajin August 20, 2024 10:29

VGalaxies force-pushed the intro-commons-v2 branch from 0b2376e to 1747d6d Compare August 21, 2024 08:00

chore(commons): basic adapt for commons migration

b087f08

VGalaxies force-pushed the intro-commons-v2 branch from 1747d6d to b087f08 Compare August 21, 2024 08:09

imbajin approved these changes Aug 22, 2024

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2024

coderzc approved these changes Aug 22, 2024

View reviewed changes

imbajin merged commit 0a0f2c3 into master Aug 22, 2024
16 of 18 checks passed

imbajin deleted the intro-commons-v2 branch August 22, 2024 11:07

VGalaxies mentioned this pull request Aug 22, 2024

chore(ci): disable merge button & rename ci job name #2646

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(commons): migrate hugegraph-commons #2628

chore(commons): migrate hugegraph-commons #2628

VGalaxies commented Aug 10, 2024 •

edited by imbajin

Loading

codecov bot commented Aug 10, 2024 •

edited

Loading

javeme commented Aug 10, 2024 •

edited

Loading

imbajin Aug 10, 2024

imbajin Aug 10, 2024

VGalaxies Aug 10, 2024 •

edited

Loading

VGalaxies Aug 21, 2024

VGalaxies commented Aug 18, 2024

imbajin commented Aug 22, 2024

chore(commons): migrate hugegraph-commons #2628

chore(commons): migrate hugegraph-commons #2628

Conversation

VGalaxies commented Aug 10, 2024 • edited by imbajin Loading

codecov bot commented Aug 10, 2024 • edited Loading

Codecov Report

javeme commented Aug 10, 2024 • edited Loading

imbajin Aug 10, 2024

Choose a reason for hiding this comment

imbajin Aug 10, 2024

Choose a reason for hiding this comment

VGalaxies Aug 10, 2024 • edited Loading

Choose a reason for hiding this comment

VGalaxies Aug 21, 2024

Choose a reason for hiding this comment

VGalaxies commented Aug 18, 2024

imbajin commented Aug 22, 2024

VGalaxies commented Aug 10, 2024 •

edited by imbajin

Loading

codecov bot commented Aug 10, 2024 •

edited

Loading

javeme commented Aug 10, 2024 •

edited

Loading

VGalaxies Aug 10, 2024 •

edited

Loading