style(store): translate Chinese comment to English #2614

Pengzna · 2024-08-04T09:25:59Z

as title.

codecov · 2024-08-04T09:33:10Z

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.95%. Comparing base (91f5b33) to head (9d3a45c).

Files	Patch %	Lines
.../hugegraph/store/business/BusinessHandlerImpl.java	0.00%	3 Missing ⚠️
...org/apache/hugegraph/store/raft/RaftOperation.java	0.00%	3 Missing ⚠️
.../apache/hugegraph/store/meta/PartitionManager.java	0.00%	2 Missing ⚠️
...in/java/org/apache/hugegraph/store/meta/Store.java	0.00%	2 Missing ⚠️
...java/org/apache/hugegraph/store/HgStoreEngine.java	0.00%	1 Missing ⚠️
...va/org/apache/hugegraph/store/PartitionEngine.java	0.00%	1 Missing ⚠️
...ache/hugegraph/store/pd/FakePdServiceProvider.java	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (91f5b33) and HEAD (9d3a45c). Click for more details.

HEAD has 2 uploads less than BASE

Flag BASE (91f5b33) HEAD (9d3a45c)

6 4

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2614      +/-   ##
============================================
- Coverage     47.12%   39.95%   -7.18%     
+ Complexity      583      532      -51     
============================================
  Files           718      729      +11     
  Lines         58441    59508    +1067     
  Branches       7492     7659     +167     
============================================
- Hits          27543    23775    -3768     
- Misses        28127    33221    +5094     
+ Partials       2771     2512     -259

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

VGalaxies · 2024-08-04T09:54:54Z

...raph-store/hg-store-cli/src/main/java/org/apache/hugegraph/store/cli/loader/HgThread2DB.java

 */
 @Slf4j
 public class HgThread2DB {

-    /*正在进行和在排队的任务的总数*/
+    /* The total number of tasks in line and queuing*/


Suggested change

/* The total number of tasks in line and queuing*/

/* The total number of tasks in line and queuing */

VGalaxies · 2024-08-04T09:56:58Z

hugegraph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/HgKvStore.java

+     * This version isstore Internal use.Write data to the partition,
+     * Partitionid andkey.keycode must be consistent with the partition information of PD storage.


Suggested change

* This version isstore Internal use.Write data to the partition,

* Partitionid andkey.keycode must be consistent with the partition information of PD storage.

* This version is store internal use. Write data to the partition,

* partitionid and key.keycode must be consistent with the partition information of PD storage.

VGalaxies · 2024-08-04T09:57:15Z

...store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodePartitionerImpl.java

@@ -48,7 +48,7 @@ public HgStoreNodePartitionerImpl(PDClient pdClient, HgStoreNodeManager nodeMana
    }

    /**
-     * 查询分区信息，结果通过HgNodePartitionerBuilder返回
+     * Query Partition Information, the result is returned through HGNODEPARTITITITITINERBUILDER


Suggested change

* Query Partition Information, the result is returned through HGNODEPARTITITITITINERBUILDER

* Query Partition Information, the result is returned through HgNodePartitionerBuilder

VGalaxies · 2024-08-04T09:57:26Z

...store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodePartitionerImpl.java

@@ -141,7 +141,7 @@ public int partition(HgNodePartitionerBuilder builder, String graphName,
    }

    /**
-     * 查询hgstore信息
+     * Inquirehgstore information


Suggested change

* Inquirehgstore information

* Inquire hgstore information

VGalaxies · 2024-08-04T09:57:42Z

...tore/hg-store-client/src/main/java/org/apache/hugegraph/store/client/NodeTxSessionProxy.java

@@ -692,7 +692,7 @@ public boolean doAction(String table, HgOwnerKey startKey, Integer code,
    }

    private List<NodeTkv> toNodeTkvList(Builder scanReqBuilder) {
-        // TODO 使用builder获取owner
+        // Todo use builder to get Owner


Suggested change

// Todo use builder to get Owner

// TODO: use builder to get owner

VGalaxies · 2024-08-04T09:59:49Z

...-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvBatchScannerMerger.java

@@ -170,7 +173,7 @@ public void add(Supplier<HgKvIterator<HgKvEntry>> supplier) {
        }

        /**
-         * 迭代器是否有效，如果没有数据，等待数据到达
+         * WHETHER the ITERATOR is value, if no data, wait for the data to arrive


Suggested change

* WHETHER the ITERATOR is value, if no data, wait for the data to arrive

* whether the iterator is valid, if no data, wait for the data to arrive

VGalaxies · 2024-08-04T10:00:17Z

...-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvBatchScannerMerger.java

@@ -221,18 +226,18 @@ private void moveNext() {
    }

    /**
-     * 对多个Scanner返回结果进行归并排序
+     * Multiplescanner return results for merger and sorting


Suggested change

* Multiplescanner return results for merger and sorting

* Multiple scanner return results for merger and sorting

VGalaxies · 2024-08-04T10:00:49Z

hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/HgStoreEngine.java

@@ -153,7 +154,7 @@ public synchronized boolean init(final HgStoreEngineOptions opts) {
    }

    /**
-     * 创建raft rpc server，用于store之间通讯
+     * Createraft RPC Server, used for communication between store


Suggested change

* Createraft RPC Server, used for communication between store

* Create raft RPC Server, used for communication between store

VGalaxies · 2024-08-04T10:01:15Z

hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/HgStoreEngine.java

            partitionManager.setStore(store);
            partitionManager.loadPartition();
            restoreLocalPartitionEngine();
        }
    }

    /**
-     * 恢复本地的PartitionEngine，恢复PD返回的分区信息
-     * 1、需要检查本次保存的分区，删除作废的分区
+     * RESTORE LOCALPARTITITITINGINE, restore the partition information returned by PD


Suggested change

* RESTORE LOCALPARTITITITINGINE, restore the partition information returned by PD

* restore local PartitionEngine, restore the partition information returned by PD

VGalaxies · 2024-08-04T10:01:31Z

hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/HgStoreEngine.java

     *
-     * @param storeId 变更的store id
+     * @param storeId changedstore id


Suggested change

* @param storeId changedstore id

* @param storeId changed store id

VGalaxies · 2024-08-04T15:28:07Z

Considering the large number of files, can be split into multiple PRs...

Using a more effective translator and matching method...

VGalaxies · 2024-08-09T10:25:36Z

close by #2623 and #2624

Pengzna added 9 commits August 4, 2024 15:43

test translation

a4f92c0

Merge remote-tracking branch 'refs/remotes/base/master'

bbc6e69

translate chinese comment

5ded706

translate pom.xml

5edad37

translate remaining files

ad5f6fb

translate remaining files

bd0e4bb

translate remaining files

f3c819d

reformat

1a1458d

fix

9d3a45c

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. store Store module labels Aug 4, 2024

Pengzna added 2 commits August 4, 2024 17:41

yml translation

3ecf327

fix - bugs

e118a57

VGalaxies mentioned this pull request Aug 4, 2024

[Summary] Preparations for Releasing HugeGraph Distributed (pd-store, 1.5) Version #2575

Open

40 tasks

VGalaxies reviewed Aug 4, 2024

View reviewed changes

VGalaxies closed this Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style(store): translate Chinese comment to English #2614

style(store): translate Chinese comment to English #2614

Pengzna commented Aug 4, 2024

codecov bot commented Aug 4, 2024 •

edited

Loading

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies Aug 4, 2024

VGalaxies commented Aug 4, 2024

VGalaxies commented Aug 9, 2024

	/* The total number of tasks in line and queuing*/
	/* The total number of tasks in line and queuing */

		* This version isstore Internal use.Write data to the partition,
		* Partitionid andkey.keycode must be consistent with the partition information of PD storage.

	* Query Partition Information, the result is returned through HGNODEPARTITITITITINERBUILDER
	* Query Partition Information, the result is returned through HgNodePartitionerBuilder

	// Todo use builder to get Owner
	// TODO: use builder to get owner

	* WHETHER the ITERATOR is value, if no data, wait for the data to arrive
	* whether the iterator is valid, if no data, wait for the data to arrive

	* Multiplescanner return results for merger and sorting
	* Multiple scanner return results for merger and sorting

	* Createraft RPC Server, used for communication between store
	* Create raft RPC Server, used for communication between store

	* RESTORE LOCALPARTITITITINGINE, restore the partition information returned by PD
	* restore local PartitionEngine, restore the partition information returned by PD

	* @param storeId changedstore id
	* @param storeId changed store id

style(store): translate Chinese comment to English #2614

style(store): translate Chinese comment to English #2614

Conversation

Pengzna commented Aug 4, 2024

codecov bot commented Aug 4, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VGalaxies commented Aug 4, 2024

VGalaxies commented Aug 9, 2024

codecov bot commented Aug 4, 2024 •

edited

Loading