Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pd): translate CJK comments to English #2536

Merged
merged 10 commits into from
May 13, 2024
Merged

chore(pd): translate CJK comments to English #2536

merged 10 commits into from
May 13, 2024

Conversation

VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented May 12, 2024

subtask of #2481

TODO: store module comment trans

@VGalaxies VGalaxies requested a review from imbajin May 12, 2024 05:25
@VGalaxies VGalaxies self-assigned this May 12, 2024
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 12, 2024
@dosubot dosubot bot added the pd PD module label May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 56.90%. Comparing base (c1e8ea5) to head (778e721).

Files Patch % Lines
...a/org/apache/hugegraph/pd/TaskScheduleService.java 0.00% 9 Missing ⚠️
...java/org/apache/hugegraph/pd/StoreNodeService.java 0.00% 5 Missing ⚠️
.../java/org/apache/hugegraph/pd/config/PDConfig.java 0.00% 3 Missing ⚠️
.../java/org/apache/hugegraph/pd/client/PDClient.java 0.00% 2 Missing ⚠️
...e/hugegraph/pd/client/AbstractClientStubProxy.java 0.00% 1 Missing ⚠️
.../java/org/apache/hugegraph/pd/client/PDConfig.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2536      +/-   ##
============================================
- Coverage     57.00%   56.90%   -0.10%     
  Complexity      827      827              
============================================
  Files           612      612              
  Lines         49654    49652       -2     
  Branches       6675     6675              
============================================
- Hits          28303    28254      -49     
- Misses        18541    18584      +43     
- Partials       2810     2814       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment in this class seems useful for new comers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recovered and translated.

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the sync

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 13, 2024
@imbajin imbajin added this to the 1.5.0 milestone May 13, 2024
@imbajin imbajin merged commit b056c5f into master May 13, 2024
14 of 16 checks passed
@imbajin imbajin deleted the trans-pd branch May 13, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer pd PD module size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants