chore: improve license header checker confs and pre-check header when validating #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
18 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2445 +/- ##
============================================
+ Coverage 66.21% 66.24% +0.03%
Complexity 828 828
============================================
Files 511 511
Lines 42598 42598
Branches 5942 5942
============================================
+ Hits 28208 28221 +13
+ Misses 11582 11566 -16
- Partials 2808 2811 +3 ☔ View full report in Codecov by Sentry. |
VGalaxies
changed the title
imbajin
previously approved these changes
Feb 7, 2024
Comment on lines
+213
to
+221
| <groupId>org.apache.rat</groupId> | ||
| <artifactId>apache-rat-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <id>license-check</id> | ||
| <goals> | ||
| <goal>check</goal> | ||
| </goals> | ||
| <phase>validate</phase> |
There was a problem hiding this comment.
if check-style plugin could also do it (consider reuse it in future)
imbajin
reviewed
Feb 7, 2024
Comment on lines
179
to
182
| <exclude>**/rocksdb-*/**</exclude> | ||
| <exclude>**/hbase-*/**</exclude> | ||
| <exclude>**/apache-cassandra-*/**</exclude> | ||
| <exclude>**/pid</exclude> |
There was a problem hiding this comment.
maybe should exclude the whole generated dir? (ignore the suggestion if it's just a test)
There was a problem hiding this comment.
These files or directories are excluded because validation is performed before using mvn test, which may include data generated from previous tests or files generated during server runtime, such as:
/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-server/apache-hugegraph-incubating-1.2.0/bin/pid
/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-server/hugegraph-test/rocksdb-data/graph/m/OPTIONS-000015
imbajin
approved these changes
Feb 20, 2024
simon824
approved these changes
Feb 23, 2024
VGalaxies
added a commit
that referenced
this pull request
Feb 23, 2024
… validating (#2445) * improve license header checker confs * typo * verify -> validate * update rat exclude files * empty commit * update rat exclude files * update rat exclude files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of #2435