-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(server): update swagger info for default server profile #2423
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2423 +/- ##
============================================
- Coverage 66.32% 66.22% -0.11%
Complexity 828 828
============================================
Files 511 511
Lines 42596 42597 +1
Branches 5942 5942
============================================
- Hits 28253 28210 -43
- Misses 11547 11577 +30
- Partials 2796 2810 +14 ☔ View full report in Codecov by Sentry. |
@@ -55,6 +55,7 @@ public class ProfileAPI { | |||
private static final String SERVICE = "hugegraph"; | |||
private static final String DOC = "https://hugegraph.apache.org/docs/"; | |||
private static final String API_DOC = DOC + "clients/"; | |||
private static final String SWAGGER_UI = "http://{domain/ip}:{port}/swagger-ui/index.html#/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we need/keep #
in the end? (whats for?_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SunnyBoy-WYH Is this as expected?
> curl http://localhost:8080/
{"service":"hugegraph","version":"1.2.0","doc":"https://hugegraph.apache.org/docs/","api_doc":"https://hugegraph.apache.org/docs/clients/","swagger_ui":"http://{domain/ip}:{port}/swagger-ui/index.html#/","apis":["arthas","auth","cypher","filter","graph","gremlin","job","metrics","profile","raft","resources","schema","traversers","variables"]}
Is there a way to fill the ip and port in swagger_ui here?
Good suggestion, maybe it's better to get the |
Yes, we can just use rest server url . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need