-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): correct the vertex id in the edge-existence api #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify pom description as well
This reverts commit 3b791ee.
11 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2380 +/- ##
============================================
- Coverage 66.31% 61.38% -4.94%
+ Complexity 830 488 -342
============================================
Files 510 510
Lines 42187 42186 -1
Branches 5840 5840
============================================
- Hits 27977 25896 -2081
- Misses 11445 13661 +2216
+ Partials 2765 2629 -136 ☔ View full report in Codecov by Sentry. |
imbajin
approved these changes
Dec 8, 2023
JackyYangPassion
approved these changes
Dec 8, 2023
imbajin
changed the title
fix: correct the vertex id conversion error in the edge-existence api
fix(api): correct the vertex id in the edge-existence api
Dec 8, 2023
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
The id obtained through GraphAPI.formatVertexId may contain unnecessary double quotation marks. It is recommended to use checkAndParseVertexId for a secure conversion.
👉:apache/incubator-hugegraph-toolchain#544 (comment)
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need