Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): add swagger desc for Arthas & Metric & Cypher & White API #2337

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

SunnyBoy-WYH
Copy link
Contributor

@SunnyBoy-WYH SunnyBoy-WYH commented Oct 25, 2023

Purpose of the PR

dd swagger belong for arthas API

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2337 (27c0d10) into master (70ab14e) will decrease coverage by 3.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2337      +/-   ##
============================================
- Coverage     68.30%   64.86%   -3.44%     
- Complexity      981      983       +2     
============================================
  Files           506      506              
  Lines         42049    42049              
  Branches       5827     5827              
============================================
- Hits          28723    27277    -1446     
- Misses        10558    12087    +1529     
+ Partials       2768     2685      -83     
Files Coverage Δ
...ava/org/apache/hugegraph/api/arthas/ArthasAPI.java 100.00% <ø> (ø)
...ava/org/apache/hugegraph/api/cypher/CypherAPI.java 60.86% <ø> (ø)
...ava/org/apache/hugegraph/api/job/AlgorithmAPI.java 0.00% <ø> (ø)
...a/org/apache/hugegraph/api/metrics/MetricsAPI.java 89.79% <ø> (ø)
...g/apache/hugegraph/api/profile/WhiteIpListAPI.java 0.00% <ø> (ø)

... and 75 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@imbajin imbajin added this to the 1.2 milestone Oct 27, 2023
javeme
javeme previously approved these changes Oct 28, 2023
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunnyBoy-WYH
Copy link
Contributor Author

image

@simon824
Copy link
Member

Hi @SunnyBoy-WYH , when we update dependency version, we need to execute ./hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh locally to update the dependency list known-dependencies.txt

@SunnyBoy-WYH
Copy link
Contributor Author

Hi @SunnyBoy-WYH , when we update dependency version, we need to execute ./hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh locally to update the dependency list known-dependencies.txt

DONE,thanks for your notice~

@SunnyBoy-WYH SunnyBoy-WYH changed the title chore(api): add swagger belong for arthas API chore(api): add swagger belong and some basic desc for Arthas & Metric & Cypher & White API Oct 30, 2023
# Conflicts:
#	hugegraph-dist/scripts/dependency/known-dependencies.txt
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin changed the title chore(api): add swagger belong and some basic desc for Arthas & Metric & Cypher & White API chore(api): add swagger desc for Arthas & Metric & Cypher & White API Nov 6, 2023
@imbajin imbajin merged commit 4d5f419 into apache:master Nov 6, 2023
16 of 21 checks passed
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Nov 10, 2023
imbajin added a commit that referenced this pull request Nov 10, 2023
…#2337)

add swagger belong for arthas API

---------

Co-authored-by: imbajin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants