-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): support embedded arthas agent in hugegraph-server #2278
Conversation
hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java
Outdated
Show resolved
Hide resolved
also refer the contribution-doc in website to fix the 3rd-party info (fix ci problems) |
Codecov Report
@@ Coverage Diff @@
## master #2278 +/- ##
============================================
+ Coverage 64.70% 64.95% +0.24%
+ Complexity 989 987 -2
============================================
Files 501 505 +4
Lines 41601 41902 +301
Branches 5799 5817 +18
============================================
+ Hits 26917 27216 +299
+ Misses 12002 11994 -8
- Partials 2682 2692 +10
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
we need handle the 3rd-party issues~ |
noted, thanks jin, i am learning how to solve it~ |
# Conflicts: # hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Could ignore RocksDB-Raft test, but it's strange that the PG tests always failed.. BTW, add the related doc in website-repo to help others know how to use it THX |
seems pass ci? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/api/arthas/ArthasAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Outdated
Show resolved
Hide resolved
public static final ConfigOption<String> ARTHAS_DISABLED_COMMANDS = | ||
new ConfigOption<>( | ||
"arthas.disabledCommands", | ||
"arthas disabled commands", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add more details for the description, since it will be as a guide for users.
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution (remember add the related doc~)
please note the CI Error when |
seems from rest-server.properties,but i am not changed configure item about auth?
|
You need to enable auth feature to build the test environment if want to run tests locally. |
got it,thanks i run it local, seems all pass except userapi/loginapi maybe we need debug mode for github ci? |
we can log case name or something for every api test case by a |
# Conflicts: # hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
The ApiTestSuite still fails, there may be some package conflicts with jraft |
hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/org/apache/hugegraph/api/BaseApiTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/org/apache/hugegraph/api/BaseApiTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/org/apache/hugegraph/api/BaseApiTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems could ignore raft-test? And it always failed now (should handle it separatly)
it's a common problem? i see 【rocksdb raft ci problem (critical, usually 360min+)】from hg tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
目的:增加 Arthas server 内嵌服务接口 (也就是说启动 HG Server 后可以直接使用 Arthas 动态观测/perf/debug, 无需单独安装)
流程:
好处:
1.一键启动Arthas后,可使用 Arthas 动态观测,无需单独安装
2.docker版本hugeGraph实现内嵌arthas
测试:
启动
http api方式与arthas交互