Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jdbc ssl mode parameter redundant #2224

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

liuxiaocs7
Copy link
Member

jdbc.sslmode is not registered, we should use jdbc.ssl_mode instead.

i see #2175 #2196 outputs have the same problem

2023-06-06 02:04:22 [main] [WARN] o.a.h.c.HugeConfig - The config option 'jdbc.sslmode' is redundant, please ensure it has been registered
2023-06-06 02:04:22 [main] [INFO] o.a.h.u.ConfigUtil - Scanning option 'graphs' directory './conf/graphs'
2023-06-06 02:04:22 [main] [INFO] o.a.h.c.InitStore - Init graph with config file: .\conf\graphs\hugegraph.properties
2023-06-06 02:04:22 [main] [WARN] o.a.h.c.HugeConfig - The config option 'jdbc.sslmode' is redundant, please ensure it has been registered

public static final ConfigOption<String> JDBC_SSL_MODE =
new ConfigOption<>(
"jdbc.ssl_mode",
"The SSL mode of connections with database.",
disallowEmpty(),
"false"
);

@liuxiaocs7 liuxiaocs7 changed the title fix: jdbc ssl mode parameter fix: jdbc ssl mode parameter redundant Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2224 (6a2b24f) into master (bcf2a39) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2224   +/-   ##
=========================================
  Coverage     65.03%   65.04%           
  Complexity      977      977           
=========================================
  Files           498      498           
  Lines         40681    40681           
  Branches       5681     5681           
=========================================
+ Hits          26457    26461    +4     
+ Misses        11597    11592    -5     
- Partials       2627     2628    +1     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, and check if the log print as expected after we rename the config

@imbajin imbajin requested review from z7658329 and zyxxoo June 6, 2023 04:42
@liuxiaocs7
Copy link
Member Author

Good, and check if the log print as expected after we rename the config

conf:

backend=mysql
serializer=mysql

# mysql backend config
jdbc.driver=com.mysql.cj.jdbc.Driver
jdbc.url=jdbc:mysql://127.0.0.1:3306
jdbc.username=root
jdbc.password=xxxxxx
jdbc.reconnect_max_times=3
jdbc.reconnect_interval=3
jdbc.ssl_mode=false

logs:

2023-06-06 14:26:04 [main] [INFO] o.a.h.u.ConfigUtil - Scanning option 'graphs' directory './conf/graphs'
2023-06-06 14:26:04 [main] [INFO] o.a.h.c.InitStore - Init graph with config file: .\conf\graphs\hugegraph.properties
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlSessions - Connect to the jdbc url: 'jdbc:mysql://127.0.0.1:3306/?socketTimeout=0&useSSL=false'
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlStore - Failed to open database 'hugegraph', try to init database later
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.c.CacheManager - Init RamCache for 'schema-id-hugegraph' with capacity 10000
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.c.CacheManager - Init RamCache for 'schema-name-hugegraph' with capacity 10000
2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlSessions - Connect to the jdbc url: 'jdbc:mysql://127.0.0.1:3306/?socketTimeout=0&useSSL=false'
main dict load finished, time elapsed 421 ms
model load finished, time elapsed 21 ms.

@javeme javeme merged commit b8c7743 into apache:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants