-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][cli] Fix start cli error #2024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
============================================
- Coverage 64.38% 58.88% -5.51%
Complexity 978 978
============================================
Files 482 482
Lines 41463 41463
Branches 5890 5890
============================================
- Hits 26698 24414 -2284
- Misses 12122 14616 +2494
+ Partials 2643 2433 -210
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# Variables | ||
INSTALL_DIR= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the comment, it requires user to set a fixed abs path manually (should't use a relative path)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. and I think should add check for Variables
@@ -37,6 +37,7 @@ | |||
### END INIT INFO | |||
|
|||
# Variables | |||
# it requires user to set a fixed abs path manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can try ${INSTALL_DIR:?"Please setting variables 'INSTALL_DIR'"}
for more details: https://stackoverflow.com/a/16753536
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javeme seems a little strange, could it use directly or test it in local evn? (or should in a if condition?)
failed with all cases in my ubuntu21
@@ -41,13 +41,15 @@ | |||
INSTALL_DIR= | |||
SERVER_PORT= | |||
|
|||
${INSTALL_DIR:?"Please setting variables 'INSTALL_DIR'"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😺, nice
typo `setting --> set``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll enhance this script later
Motivation
Run
bin/hugegraph start
errorModifications
Add check for
Variables