Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpc version to support build on apple m1 #1914

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

hezhangjian
Copy link
Member

@hezhangjian hezhangjian commented Jun 30, 2022

tested on my m1 mbp

For additional information, we can see
apache/pulsar#13076
apache/pulsar#16306

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1914 (bfc717f) into master (b54fba6) will increase coverage by 4.34%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1914      +/-   ##
============================================
+ Coverage     66.17%   70.52%   +4.34%     
  Complexity      962      962              
============================================
  Files           452      452              
  Lines         38778    38792      +14     
  Branches       5527     5527              
============================================
+ Hits          25661    27357    +1696     
+ Misses        10601     8761    -1840     
- Partials       2516     2674     +158     
Impacted Files Coverage Δ
...hugegraph/backend/store/raft/rpc/RaftRequests.java 20.12% <ø> (+18.15%) ⬆️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.14% <0.00%> (+0.20%) ⬆️
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 72.22% <0.00%> (+0.30%) ⬆️
...va/com/baidu/hugegraph/util/collection/IntMap.java 72.80% <0.00%> (+0.39%) ⬆️
...gegraph/backend/cache/CachedSchemaTransaction.java 90.33% <0.00%> (+0.48%) ⬆️
...om/baidu/hugegraph/task/StandardTaskScheduler.java 75.56% <0.00%> (+0.49%) ⬆️
.../main/java/com/baidu/hugegraph/util/Consumers.java 56.84% <0.00%> (+0.68%) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 79.09% <0.00%> (+0.69%) ⬆️
.../java/com/baidu/hugegraph/task/HugeServerInfo.java 74.63% <0.00%> (+0.72%) ⬆️
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java 57.20% <0.00%> (+0.72%) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54fba6...bfc717f. Read the comment docs.

@imbajin
Copy link
Member

imbajin commented Jun 30, 2022

Thanks for your contribution, is there anyway to test the diff (or ensure it's fine on m1)?

@seagle-yuan any suggestion or could we test it?

@hezhangjian
Copy link
Member Author

@imbajin Sorry, I forget to fill how I test it. I have test it on my mbp. It can package well.
For additional information, we can see
apache/pulsar#13076
apache/pulsar#16306

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one tiny comment

@@ -60,13 +60,19 @@ public final int getNumber() {
}

/**
* @param value The numeric wire value of the corresponding enum entry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not update RaftRequests.java file?

@hezhangjian
Copy link
Member Author

@javeme I think we should update the RaftRequests.java. It's generated by grpc. We should keep it consistent.
We'd better not commit this file to the repository, but that's another optimization point.

@hezhangjian
Copy link
Member Author

can this pr be merged? what should I do next? @javeme @imbajin

@javeme javeme merged commit 70cf9d0 into apache:master Jul 4, 2022
@hezhangjian hezhangjian deleted the bump-grpc-version-support-m1 branch July 4, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants