-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump grpc version to support build on apple m1 #1914
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
============================================
+ Coverage 66.17% 70.52% +4.34%
Complexity 962 962
============================================
Files 452 452
Lines 38778 38792 +14
Branches 5527 5527
============================================
+ Hits 25661 27357 +1696
+ Misses 10601 8761 -1840
- Partials 2516 2674 +158
Continue to review full report at Codecov.
|
Thanks for your contribution, is there anyway to test the diff (or ensure it's fine on m1)? @seagle-yuan any suggestion or could we test it? |
@imbajin Sorry, I forget to fill how I test it. I have test it on my mbp. It can package well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one tiny comment
@@ -60,13 +60,19 @@ public final int getNumber() { | |||
} | |||
|
|||
/** | |||
* @param value The numeric wire value of the corresponding enum entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not update RaftRequests.java file?
@javeme I think we should update the |
tested on my m1 mbp
For additional information, we can see
apache/pulsar#13076
apache/pulsar#16306