Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: limit admin role can drop graph #1878

Merged
merged 1 commit into from
May 13, 2022

Conversation

wangyao2016
Copy link
Contributor

Since admin permission is required for create and clear graph, so drop should also be admin permission.

image

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1878 (5cc24f8) into master (f6f8c3e) will decrease coverage by 4.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1878      +/-   ##
============================================
- Coverage     70.95%   66.89%   -4.07%     
- Complexity      695      728      +33     
============================================
  Files           447      449       +2     
  Lines         38077    38116      +39     
  Branches       5401     5404       +3     
============================================
- Hits          27019    25496    -1523     
- Misses         8412    10103    +1691     
+ Partials       2646     2517     -129     
Impacted Files Coverage Δ
...ava/com/baidu/hugegraph/api/profile/GraphsAPI.java 0.00% <ø> (ø)
...hugegraph/backend/store/raft/RaftStoreClosure.java 0.00% <0.00%> (-100.00%) ⬇️
...ugegraph/backend/store/rocksdb/RocksDBMetrics.java 0.00% <0.00%> (-85.87%) ⬇️
...baidu/hugegraph/backend/store/raft/RaftResult.java 0.00% <0.00%> (-81.25%) ⬇️
...ugegraph/backend/store/raft/RaftSharedContext.java 0.00% <0.00%> (-80.00%) ⬇️
...gegraph/backend/store/rocksdb/RocksDBFeatures.java 8.33% <0.00%> (-79.17%) ⬇️
...hugegraph/backend/store/raft/RaftBackendStore.java 0.00% <0.00%> (-75.00%) ⬇️
...hugegraph/backend/store/raft/rpc/RpcForwarder.java 0.00% <0.00%> (-69.50%) ⬇️
...h/backend/store/raft/RaftBackendStoreProvider.java 0.00% <0.00%> (-67.65%) ⬇️
.../backend/store/raft/rpc/StoreCommandProcessor.java 0.00% <0.00%> (-65.22%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f8c3e...5cc24f8. Read the comment docs.

@imbajin imbajin merged commit 239b06e into apache:master May 13, 2022
@javeme javeme changed the title improve allow role for drop graph improve: limit admin role can drop graph Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants