Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ClassTypeParameterName check #1833

Closed
wants to merge 5 commits into from
Closed

improve ClassTypeParameterName check #1833

wants to merge 5 commits into from

Conversation

seagle-yuan
Copy link
Contributor

improve ClassTypeParameterName check
the regular expression of "ClassTypeParameterName "
from "(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9][T]$)" to "[A-Z][a-zA-Z0-9]$"

@imbajin
Copy link
Member

imbajin commented Apr 19, 2022

Due to CI has some troubles now, we could add more commit then wait for it

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1833 (8291f5b) into master (9a8259e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1833      +/-   ##
============================================
+ Coverage     66.93%   66.94%   +0.01%     
  Complexity      444      444              
============================================
  Files           446      446              
  Lines         37966    37966              
  Branches       5410     5410              
============================================
+ Hits          25413    25417       +4     
+ Misses         9957     9955       -2     
+ Partials       2596     2594       -2     
Impacted Files Coverage Δ
...aidu/hugegraph/backend/store/hbase/HbaseTable.java 75.46% <0.00%> (-0.62%) ⬇️
...du/hugegraph/backend/tx/GraphIndexTransaction.java 83.54% <0.00%> (+0.10%) ⬆️
...va/com/baidu/hugegraph/util/collection/IntMap.java 72.00% <0.00%> (+0.40%) ⬆️
...va/com/baidu/hugegraph/util/collection/IntSet.java 74.89% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8259e...8291f5b. Read the comment docs.

@seagle-yuan
Copy link
Contributor Author

It seems like that we can't pass the test.
1
2
3

@imbajin
Copy link
Member

imbajin commented Apr 22, 2022

It seems like that we can't pass the test. 1 2 3

seems it was a bug, submit a new bug issue to solve it maybe (the master branch also have this problem)

image

@javeme
Copy link
Contributor

javeme commented Apr 22, 2022

Not sure why there are ci errors with cassandra backend:

[INFO] Running com.baidu.hugegraph.api.ApiTestSuite
Error:  Tests run: 86, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 54.335 s <<< FAILURE! - in com.baidu.hugegraph.api.ApiTestSuite
Error:  testMetricsBackend(com.baidu.hugegraph.api.MetricsApiTest)  Time elapsed: 0.113 s  <<< FAILURE!
java.lang.AssertionError: Expect contains key 'mem_max' in {exception=java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.InvalidNameException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199 [Root exception is java.lang.IllegalArgumentException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199]}
	at com.baidu.hugegraph.api.MetricsApiTest.testMetricsBackend(MetricsApiTest.java:173)

[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    MetricsApiTest.testMetricsBackend:173->BaseApiTest.assertMapContains:631 Expect contains key 'mem_max' in {exception=java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.InvalidNameException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199 [Root exception is java.lang.IllegalArgumentException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199]}
[INFO] 
Error:  Tests run: 86, Failures: 1, Errors: 0, Skipped: 0

@seagle-yuan
Copy link
Contributor Author

can you help me reopen ?

Copy link
Contributor Author

@seagle-yuan seagle-yuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recheck

@javeme
Copy link
Contributor

javeme commented Apr 25, 2022

please update the latest code:

git remote add apache https://github.com/apache/incubator-hugegraph
git checkout master
git pull apache
git checkout checkstyle-check
git merge master
git push

@seagle-yuan
Copy link
Contributor Author

remove to #1850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants