-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve ClassTypeParameterName check #1833
Conversation
Due to CI has some troubles now, we could add more commit then wait for it |
Codecov Report
@@ Coverage Diff @@
## master #1833 +/- ##
============================================
+ Coverage 66.93% 66.94% +0.01%
Complexity 444 444
============================================
Files 446 446
Lines 37966 37966
Branches 5410 5410
============================================
+ Hits 25413 25417 +4
+ Misses 9957 9955 -2
+ Partials 2596 2594 -2
Continue to review full report at Codecov.
|
Not sure why there are ci errors with cassandra backend: [INFO] Running com.baidu.hugegraph.api.ApiTestSuite
Error: Tests run: 86, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 54.335 s <<< FAILURE! - in com.baidu.hugegraph.api.ApiTestSuite
Error: testMetricsBackend(com.baidu.hugegraph.api.MetricsApiTest) Time elapsed: 0.113 s <<< FAILURE!
java.lang.AssertionError: Expect contains key 'mem_max' in {exception=java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.InvalidNameException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199 [Root exception is java.lang.IllegalArgumentException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199]}
at com.baidu.hugegraph.api.MetricsApiTest.testMetricsBackend(MetricsApiTest.java:173)
[INFO]
[INFO] Results:
[INFO]
Error: Failures:
Error: MetricsApiTest.testMetricsBackend:173->BaseApiTest.assertMapContains:631 Expect contains key 'mem_max' in {exception=java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.InvalidNameException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199 [Root exception is java.lang.IllegalArgumentException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199]}
[INFO]
Error: Tests run: 86, Failures: 1, Errors: 0, Skipped: 0 |
can you help me reopen ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recheck
please update the latest code: git remote add apache https://github.com/apache/incubator-hugegraph
git checkout master
git pull apache
git checkout checkstyle-check
git merge master
git push |
remove to #1850 |
improve ClassTypeParameterName check
the regular expression of "ClassTypeParameterName "
from "(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9][T]$)" to "[A-Z][a-zA-Z0-9]$"