Fix close exception and server-info EXPIRED_INTERVAL #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyxxoo
force-pushed
the
fix_close_exception
branch
from
2eb6c9b to
f141447
Compare
Codecov Report
@@ Coverage Diff @@
## master #1804 +/- ##
============================================
+ Coverage 66.93% 70.90% +3.96%
- Complexity 980 982 +2
============================================
Files 446 446
Lines 37781 37902 +121
Branches 5380 5398 +18
============================================
+ Hits 25289 26873 +1584
+ Misses 9768 8299 -1469
- Partials 2724 2730 +6
Continue to review full report at Codecov.
|
javeme
reviewed
Mar 31, 2022
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/ContextGremlinServer.java
Show resolved
Hide resolved
hugegraph-dist/src/main/java/com/baidu/hugegraph/dist/HugeGraphServer.java
Outdated
Show resolved
Hide resolved
hugegraph-dist/src/main/java/com/baidu/hugegraph/dist/HugeGraphServer.java
Outdated
Show resolved
Hide resolved
| * eventHub execute notify event on a shutdown executor, so here | ||
| * remove the HugeFactory shutdown hook. | ||
| */ | ||
| HugeFactory.removeShutdownHook(); |
There was a problem hiding this comment.
also add graph.tx().close() to checkVersionOrExit()
There was a problem hiding this comment.
now, threadpool wait graph close, but close check tx all close(need threadpool shutdown), so here is a conflict, so we resolve this problem must close before notify thread close tx(AOP threadpool), maybe i can do it after java11 code be merged
javeme
reviewed
Mar 31, 2022
hugegraph-dist/src/main/java/com/baidu/hugegraph/dist/HugeGraphServer.java
Outdated
Show resolved
Hide resolved
zyxxoo
force-pushed
the
fix_close_exception
branch
from
7c90f05 to
31fb13f
Compare
zyxxoo
force-pushed
the
fix_close_exception
branch
from
31fb13f to
5a851d7
Compare
javeme
reviewed
Mar 31, 2022
hugegraph-api/src/main/java/com/baidu/hugegraph/core/GraphManager.java
Outdated
Show resolved
Hide resolved
hugegraph-dist/src/main/java/com/baidu/hugegraph/dist/HugeGraphServer.java
Show resolved
Hide resolved
javeme
approved these changes
Apr 7, 2022
javeme
changed the title
imbajin
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix "The server with name xx already in cluster"