Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal tweaks #1797

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Proposal tweaks #1797

merged 2 commits into from
Mar 30, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 25, 2022

If this document isn't a living document, it should be tagged as such.

Otherwise, I'd hope you'd accept some minor tweaks.

I typically provide much simpler fixes across repositories. I've queued that task but don't expect to look into it until long after this PR is resolved.

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Mar 25, 2022

CLA Assistant Lite bot Good! All Contributors have signed the CLA.

@jsoref
Copy link
Contributor Author

jsoref commented Mar 25, 2022

recheck

@imbajin
Copy link
Member

imbajin commented Mar 27, 2022

Thanks for contribution, and wonder is there any way to auto-check typo for code comment? (like a github action/plugin)

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #1797 (f73fc67) into master (b591f7d) will increase coverage by 3.93%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1797      +/-   ##
============================================
+ Coverage     66.91%   70.85%   +3.93%     
+ Complexity      978      976       -2     
============================================
  Files           446      446              
  Lines         37781    37781              
  Branches       5380     5380              
============================================
+ Hits          25281    26768    +1487     
+ Misses         9776     8291    -1485     
+ Partials       2724     2722       -2     
Impacted Files Coverage Δ
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.08% <0.00%> (+0.10%) ⬆️
...du/hugegraph/backend/tx/GraphIndexTransaction.java 83.82% <0.00%> (+0.21%) ⬆️
...du/hugegraph/traversal/optimize/TraversalUtil.java 62.87% <0.00%> (+0.21%) ⬆️
.../baidu/hugegraph/backend/query/ConditionQuery.java 85.64% <0.00%> (+0.24%) ⬆️
...du/hugegraph/schema/builder/IndexLabelBuilder.java 88.69% <0.00%> (+0.28%) ⬆️
.../com/baidu/hugegraph/auth/StandardAuthManager.java 92.81% <0.00%> (+0.32%) ⬆️
...idu/hugegraph/schema/builder/EdgeLabelBuilder.java 83.62% <0.00%> (+0.34%) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 77.97% <0.00%> (+0.36%) ⬆️
...u/hugegraph/schema/builder/VertexLabelBuilder.java 87.54% <0.00%> (+0.37%) ⬆️
.../java/com/baidu/hugegraph/backend/query/Query.java 86.11% <0.00%> (+0.39%) ⬆️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b591f7d...f73fc67. Read the comment docs.

@jsoref
Copy link
Contributor Author

jsoref commented Mar 27, 2022

Yes. That's what my next PR would be based around. https://check-spelling.dev

@jsoref
Copy link
Contributor Author

jsoref commented Mar 28, 2022

I have read the CLA Document and I hereby sign the CLA

@jsoref
Copy link
Contributor Author

jsoref commented Mar 28, 2022

Fwiw, that PR is up as #1798

github-actions bot added a commit that referenced this pull request Mar 28, 2022
APACHE_PROPOSAL.md Outdated Show resolved Hide resolved
@jsoref jsoref mentioned this pull request Mar 28, 2022
@javeme javeme merged commit 0cc02e4 into apache:master Mar 30, 2022
@jsoref jsoref deleted the proposal-tweaks branch March 30, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants