Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackendEntry.columns() var-arg to single-arg avoid array-construct #1787

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Mar 18, 2022

Change-Id: If073179a68e9207999cc07f4661e29c2c61282a3

Change-Id: If073179a68e9207999cc07f4661e29c2c61282a3
@github-actions
Copy link

github-actions bot commented Mar 18, 2022

CLA Assistant Lite bot Good! All Contributors have signed the CLA.

@javeme
Copy link
Contributor Author

javeme commented Mar 18, 2022

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 18, 2022
Change-Id: Ie2e05350ddbee5998462658ce5199c8ee83e03fc
@javeme
Copy link
Contributor Author

javeme commented Mar 18, 2022

recheck

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1787 (ac8b8bd) into master (730f332) will increase coverage by 3.98%.
The diff coverage is 79.41%.

@@             Coverage Diff              @@
##             master    #1787      +/-   ##
============================================
+ Coverage     66.85%   70.83%   +3.98%     
- Complexity      972      976       +4     
============================================
  Files           443      446       +3     
  Lines         37738    37793      +55     
  Branches       5381     5384       +3     
============================================
+ Hits          25229    26772    +1543     
+ Misses         9788     8297    -1491     
- Partials       2721     2724       +3     
Impacted Files Coverage Δ
...ugegraph/backend/serializer/TableBackendEntry.java 88.88% <ø> (-0.12%) ⬇️
...gegraph/backend/serializer/BinaryBackendEntry.java 78.40% <33.33%> (+3.96%) ⬆️
...om/baidu/hugegraph/backend/store/BackendEntry.java 71.42% <80.76%> (+40.87%) ⬆️
...hugegraph/backend/serializer/TextBackendEntry.java 83.23% <100.00%> (-0.20%) ⬇️
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 68.53% <100.00%> (+53.84%) ⬆️
.../baidu/hugegraph/security/HugeSecurityManager.java 78.74% <0.00%> (-1.76%) ⬇️
...va/com/baidu/hugegraph/util/collection/IntSet.java 73.61% <0.00%> (-1.28%) ⬇️
...in/java/com/baidu/hugegraph/auth/HugeResource.java 78.08% <0.00%> (-0.49%) ⬇️
...om/baidu/hugegraph/backend/store/ram/RamTable.java 66.55% <0.00%> (-0.23%) ⬇️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730f332...ac8b8bd. Read the comment docs.

Change-Id: Ib422fb1f126e11cf331464ac7f9e05ad0564846d
@javeme javeme force-pushed the BackendEntry.columns-var-arg branch from 96bbadd to ac8b8bd Compare March 21, 2022 12:04
@imbajin imbajin merged commit 74c0e2d into master Apr 18, 2022
@imbajin imbajin deleted the BackendEntry.columns-var-arg branch April 18, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants