-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cache metrics perf issue #1515
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ifac465520f646d07f1ffbd60a3e5f36d1b1985ce
Change-Id: Ifeb44103c8998cbbd484d27d5660c08271699458
imbajin
previously approved these changes
Jun 24, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/cache/AbstractCache.java
Outdated
Show resolved
Hide resolved
Change-Id: I486b8feefa76a7ac3b7ca44f23285c6e3ebe780f
Codecov Report
@@ Coverage Diff @@
## master #1515 +/- ##
============================================
- Coverage 60.02% 59.47% -0.55%
- Complexity 305 6114 +5809
============================================
Files 426 406 -20
Lines 35096 33066 -2030
Branches 4970 4574 -396
============================================
- Hits 21065 19666 -1399
+ Misses 11894 11336 -558
+ Partials 2137 2064 -73
Continue to review full report at Codecov.
|
Change-Id: I9bd9f48a7dc35ab9c42cbc141e0a54824c974b36
imbajin
previously approved these changes
Jun 24, 2021
zhoney
previously approved these changes
Jun 24, 2021
Change-Id: Ic613f1d387dae26cc3cd6b69346d28a912453f72
imbajin
approved these changes
Jun 24, 2021
jadepeng
pushed a commit
to jadepeng/hugegraph
that referenced
this pull request
Jun 25, 2021
* fix cache metrics perf issue * enable cache metrics for graph cache * add collectMetrics() * move containsKey into access * fix not call access() when size > halfCapacity Change-Id: Ifac465520f646d07f1ffbd60a3e5f36d1b1985ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test perf on Mac (8 CPUs) with threads=10 loop=8kw: