Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: let kout degree applied to all labels & remove source vertex from kneighbor default results #1459

Merged
merged 4 commits into from
May 21, 2021

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented May 19, 2021

Contains 3 point:

  1. kout degree applied to all labels
  2. remove source vertex from default kneighbor result
  3. fix kneighbor result with limit may loss data because the duplicate elements of current layer are not excluded

PS: Also remove LimitIterator (moved to common) & add/adapt test for them on client#122

also remove LimitIterator (moved to common)
@imbajin imbajin requested review from javeme and zhoney May 19, 2021 12:03
@imbajin imbajin changed the title refactor: let kout degree applied to all labels refact: let kout degree applied to all labels & remove source vertex from kneighbor default results May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1459 (1a174db) into master (1ede97c) will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1459      +/-   ##
============================================
+ Coverage     61.80%   62.17%   +0.36%     
- Complexity     5840     5863      +23     
============================================
  Files           381      381              
  Lines         32148    32177      +29     
  Branches       4504     4504              
============================================
+ Hits          19869    20005     +136     
+ Misses        10231    10119     -112     
- Partials       2048     2053       +5     
Impacted Files Coverage Δ Complexity Δ
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.02% <ø> (+0.06%) 306.00 <0.00> (ø)
.../hugegraph/backend/store/rocksdb/RocksDBStore.java 69.61% <0.00%> (-1.79%) 71.00% <0.00%> (+1.00%) ⬇️
.../com/baidu/hugegraph/auth/StandardAuthManager.java 93.20% <0.00%> (-0.99%) 62.00% <0.00%> (ø%)
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 69.53% <0.00%> (-0.31%) 81.00% <0.00%> (-1.00%)
...ugegraph/backend/store/raft/StoreSnapshotFile.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ugegraph/backend/store/raft/StoreStateMachine.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...va/com/baidu/hugegraph/backend/page/PageState.java 97.29% <0.00%> (+0.07%) 14.00% <0.00%> (ø%)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 81.15% <0.00%> (+0.11%) 203.00% <0.00%> (ø%)
...a/com/baidu/hugegraph/backend/query/Condition.java 78.46% <0.00%> (+0.36%) 32.00% <0.00%> (ø%)
.../baidu/hugegraph/backend/query/ConditionQuery.java 86.40% <0.00%> (+0.40%) 106.00% <0.00%> (+1.00%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ede97c...1a174db. Read the comment docs.

zhoney
zhoney previously approved these changes May 20, 2021
@zhoney zhoney merged commit 718daa6 into master May 21, 2021
@zhoney zhoney deleted the fix-kout-degree branch May 21, 2021 12:30
zhoney pushed a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants