Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graph read mode and set/list aggregate property #1332

Merged
merged 6 commits into from
Jan 14, 2021
Merged

Support graph read mode and set/list aggregate property #1332

merged 6 commits into from
Jan 14, 2021

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented Jan 13, 2021

No description provided.

zhoney added 5 commits January 13, 2021 17:07
@zhoney
add GraphReadMode
c2b590f 
Change-Id: Ic2e651970193b16e7e94fe2c73e58392079a2af5
@zhoney
support OLAP property key
3848ae6 
Change-Id: Ic8d18c111d016cb12ee0fa62a847205b72c7a5b7
@zhoney
support aggregate type set and list
a953400 
Change-Id: Id0b3c025a93112f6dfaaa0e0f886ba9a35a40fc8
@zhoney
update tests for olap property key
e5f417c 
Change-Id: I1e1f906b76c5fdba65cb16b7269697d3100ae054
@zhoney
upgrade api version to 0.59
7bfc0a3 
Change-Id: I18d999df2a7dd64f4e95926ca06d1caabd28193e
@codecov
Copy link

codecov bot commented Jan 13, 2021 •
edited
Loading

Codecov Report

Merging #1332 (64f0e04) into master (e0f36bd) will decrease coverage by 0.01%.
The diff coverage is 59.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1332      +/-   ##
============================================
- Coverage     62.32%   62.31%   -0.02%     
- Complexity     5770     5799      +29     
============================================
  Files           377      379       +2     
  Lines         31553    31657     +104     
  Branches       4422     4434      +12     
============================================
+ Hits          19666    19727      +61     
- Misses         9887     9924      +37     
- Partials       2000     2006       +6
Impacted Files Coverage Δ Complexity Δ
...ava/com/baidu/hugegraph/api/profile/GraphsAPI.java 24.44% <0.00%> (-5.29%) 0.00 <0.00> (ø)
...com/baidu/hugegraph/api/schema/PropertyKeyAPI.java 48.38% <0.00%> (-1.62%) 0.00 <0.00> (ø)
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java 4.02% <0.00%> (-0.04%) 0.00 <0.00> (ø)
...aph/backend/store/cassandra/CassandraFeatures.java 80.95% <0.00%> (-4.05%) 17.00 <0.00> (ø)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 65.30% <ø> (ø) 9.00 <0.00> (ø)
...baidu/hugegraph/backend/store/BackendFeatures.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ugegraph/backend/store/memory/InMemoryDBStore.java 86.89% <0.00%> (-0.61%) 32.00 <0.00> (ø)
...idu/hugegraph/job/schema/RebuildIndexCallable.java 76.82% <ø> (ø) 21.00 <0.00> (ø)
...u/hugegraph/backend/store/hbase/HbaseFeatures.java 85.71% <0.00%> (-4.29%) 18.00 <0.00> (ø)
...u/hugegraph/backend/store/mysql/MysqlFeatures.java 80.95% <0.00%> (-4.05%) 17.00 <0.00> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f36bd...64f0e04. Read the comment docs.

javeme
javeme reviewed Jan 14, 2021
View reviewed changes
hugegraph-core/src/main/java/com/baidu/hugegraph/HugeGraphParams.java Outdated
@@ -40,6 +41,7 @@
public HugeGraph graph();
public String name();
public GraphMode mode();
public GraphReadMode graphReadMode();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readMode

hugegraph-core/src/main/java/com/baidu/hugegraph/schema/PropertyKey.java Outdated
@@ -45,12 +45,14 @@
private DataType dataType;
private Cardinality cardinality;
private AggregateType aggregateType;
private boolean olap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer define enum ReadFrequency include OLTP and OLAP, maybe we'll add OLTP_COLD in the future

hugegraph-test/src/main/java/com/baidu/hugegraph/core/EdgeCoreTest.java
edge = graph.traversal().V("10.0.0.1").outE().next();
Assert.assertEquals(Utils.date("2019-1-1 00:00:00"),
edge.value("startTime"));
Assert.assertEquals(Utils.date("2019-2-1 00:20:00"),
edge.value("endTime"));
Assert.assertEquals(120L, edge.value("times"));
Assert.assertEquals(ImmutableSet.of(21, 22, 23),
edge.value("port"));
Assert.assertEquals(ImmutableList.of(21, 22, 23, 23),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calcList effected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@zhoney
add ReadFrequency
64f0e04 
Change-Id: I5db5a1bc91c14b659bbba27c2ad15b40245bc62a
@Linary Linary merged commit 59a680c into master Jan 14, 2021
@Linary Linary deleted the read-mode-and-set-list-agg branch January 14, 2021 14:11
@zhoney zhoney mentioned this pull request Jul 2, 2021
Closed
@javeme javeme changed the title Support graph read mode and set list aggregate property Support graph read mode and set/list aggregate property Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javeme javeme javeme approved these changes

@Linary Linary Linary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhoney @Linary @javeme