fix ttl not work due to job not close tx #1330

zhoney · 2021-01-12T08:10:20Z

Change-Id: Ic4a3bc11e67f92c88772149d5c304a2c1da0ec64

codecov · 2021-01-12T08:38:02Z

Codecov Report

Merging #1330 (4047231) into master (26ac664) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1330      +/-   ##
============================================
+ Coverage     61.88%   62.32%   +0.43%     
- Complexity     5751     5770      +19     
============================================
  Files           377      377              
  Lines         31543    31553      +10     
  Branches       4419     4422       +3     
============================================
+ Hits          19521    19666     +145     
+ Misses        10029     9887     -142     
- Partials       1993     2000       +7

Impacted Files	Coverage Δ	Complexity Δ
.../src/main/java/com/baidu/hugegraph/job/SysJob.java	`75.00% <100.00%> (+3.57%)`	`3.00 <1.00> (ø)`
...src/main/java/com/baidu/hugegraph/job/UserJob.java	`100.00% <100.00%> (ø)`	`4.00 <1.00> (ø)`
...in/java/com/baidu/hugegraph/task/TaskCallable.java	`60.65% <100.00%> (+3.51%)`	`13.00 <3.00> (+2.00)`
...n/java/com/baidu/hugegraph/schema/PropertyKey.java	`77.09% <0.00%> (-0.60%)`	`51.00% <0.00%> (ø%)`
...in/java/com/baidu/hugegraph/StandardHugeGraph.java	`78.98% <0.00%> (-0.39%)`	`119.00% <0.00%> (+1.00%)`	⬇️
...aidu/hugegraph/schema/builder/AbstractBuilder.java	`89.28% <0.00%> (-0.37%)`	`13.00% <0.00%> (-1.00%)`
...aidu/hugegraph/backend/tx/AbstractTransaction.java	`72.90% <0.00%> (-0.35%)`	`51.00% <0.00%> (-2.00%)`
...om/baidu/hugegraph/task/StandardTaskScheduler.java	`77.44% <0.00%> (-0.23%)`	`85.00% <0.00%> (-2.00%)`
.../baidu/hugegraph/backend/tx/SchemaTransaction.java	`91.50% <0.00%> (-0.05%)`	`70.00% <0.00%> (ø%)`
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java	`65.30% <0.00%> (ø)`	`9.00% <0.00%> (ø%)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ac664...4047231. Read the comment docs.

javeme · 2021-01-12T10:44:25Z

hugegraph-core/src/main/java/com/baidu/hugegraph/task/TaskCallable.java

    }

    protected void cancelled() {
        // Do nothing, subclasses may override this method
    }

+    protected void closeTx() {
+        if (this.graph().tx().isOpen()) {


define tx first

Change-Id: I0f473063f6df1e43170f01a655a87a1c790f028a

fix ttl not work due to job not close tx

921efba

Change-Id: Ic4a3bc11e67f92c88772149d5c304a2c1da0ec64

javeme requested changes Jan 12, 2021

View reviewed changes

improve

4047231

Change-Id: I0f473063f6df1e43170f01a655a87a1c790f028a

javeme approved these changes Jan 13, 2021

View reviewed changes

Linary approved these changes Jan 13, 2021

View reviewed changes

Linary merged commit e0f36bd into master Jan 13, 2021

Linary deleted the fix-gremlin-job-ttl branch January 13, 2021 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix ttl not work due to job not close tx #1330

fix ttl not work due to job not close tx #1330

zhoney commented Jan 12, 2021

codecov bot commented Jan 12, 2021 •

edited

Loading

javeme Jan 12, 2021

fix ttl not work due to job not close tx #1330

fix ttl not work due to job not close tx #1330

Conversation

zhoney commented Jan 12, 2021

codecov bot commented Jan 12, 2021 • edited Loading

Codecov Report

javeme Jan 12, 2021

Choose a reason for hiding this comment

codecov bot commented Jan 12, 2021 •

edited

Loading