add test case

apache · Jun 17, 2021 · 1c9c0e9 · 1c9c0e9
1 parent cea7c08
commit 1c9c0e9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/hugegraph-core/src/main/java/com/baidu/hugegraph/backend/cache/AbstractCache.java b/hugegraph-core/src/main/java/com/baidu/hugegraph/backend/cache/AbstractCache.java
@@ -185,7 +185,7 @@ public long tick() {
         long current = now();
         for (Iterator<CacheNode<K, V>> it = this.nodes(); it.hasNext();) {
             CacheNode<K, V> node = it.next();
-            if (current - node.time() > expireTime) {
+            if (current - node.time() >= expireTime) {
                 // Remove item while iterating map (it must be ConcurrentMap)
                 this.remove(node.key());
                 expireItems++;

diff --git a/hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cache/CacheTest.java b/hugegraph-test/src/main/java/com/baidu/hugegraph/unit/cache/CacheTest.java
@@ -59,7 +59,7 @@ public void teardown() throws Exception {
 
     protected abstract Cache<Id, Object> newCache();
 
-    protected abstract Cache<Id, Object> newCache(long capacity) ;
+    protected abstract Cache<Id, Object> newCache(long capacity);
 
     protected abstract void checkSize(Cache<Id, Object> cache, long size,
                                       Map<Id, Object> kvs);
@@ -673,5 +673,24 @@ public void testMutiThreadsGetAndUpdateWithGtCapacity() {
         // In fact, the size may be any value(such as 43)
         Assert.assertTrue(cache.size() < 10 + THREADS_NUM);
     }
+
+    @Test
+    public void testKeyExpired() {
+        Cache<Id, Object> cache = newCache();
+        cache.expire(2000L);
+
+        Id key = IdGenerator.of("key");
+        cache.update(key, "value", -1000L);
+
+        waitTillNext(1);
+        cache.tick();
+
+        Assert.assertFalse(cache.containsKey(key));
+
+        cache.update(key, "value", -2000L);
+        cache.tick();
+
+        Assert.assertFalse(cache.containsKey(key));
+    }
 }