tiny improve

Change-Id: I86e7fa5776c5618033a09d1a61c6351eb98048a7
apache · Oct 14, 2019 · 145951f · 145951f
1 parent 3464734
commit 145951f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/schema/EdgeLabelAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/schema/EdgeLabelAPI.java
@@ -108,15 +108,16 @@ public String update(@Context GraphManager manager,
     public String list(@Context GraphManager manager,
                        @PathParam("graph") String graph,
                        @QueryParam("names") List<String> names) {
-        if (CollectionUtils.isEmpty(names)) {
+        boolean listAll = CollectionUtils.isEmpty(names);
+        if (listAll) {
             LOG.debug("Graph [{}] list edge labels", graph);
         } else {
             LOG.debug("Graph [{}] get edge labels by names {}", graph, names);
         }
 
         HugeGraph g = graph(manager, graph);
         List<EdgeLabel> labels;
-        if (CollectionUtils.isEmpty(names)) {
+        if (listAll) {
             labels = g.schema().getEdgeLabels();
         } else {
             labels = new ArrayList<>(names.size());

diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/schema/IndexLabelAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/schema/IndexLabelAPI.java
@@ -83,15 +83,16 @@ public String create(@Context GraphManager manager,
     public String list(@Context GraphManager manager,
                        @PathParam("graph") String graph,
                        @QueryParam("names") List<String> names) {
-        if (CollectionUtils.isEmpty(names)) {
+        boolean listAll = CollectionUtils.isEmpty(names);
+        if (listAll) {
             LOG.debug("Graph [{}] list index labels", graph);
         } else {
             LOG.debug("Graph [{}] get index labels by names {}", graph, names);
         }
 
         HugeGraph g = graph(manager, graph);
         List<IndexLabel> labels;
-        if (CollectionUtils.isEmpty(names)) {
+        if (listAll) {
             labels = g.schema().getIndexLabels();
         } else {
             labels = new ArrayList<>(names.size());

diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/schema/PropertyKeyAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/schema/PropertyKeyAPI.java
@@ -110,15 +110,16 @@ public String update(@Context GraphManager manager,
     public String list(@Context GraphManager manager,
                        @PathParam("graph") String graph,
                        @QueryParam("names") List<String> names) {
-        if (CollectionUtils.isEmpty(names)) {
+        boolean listAll = CollectionUtils.isEmpty(names);
+        if (listAll) {
             LOG.debug("Graph [{}] list property keys", graph);
         } else {
             LOG.debug("Graph [{}] get property keys by names {}", graph, names);
         }
 
         HugeGraph g = graph(manager, graph);
         List<PropertyKey> propKeys;
-        if (CollectionUtils.isEmpty(names)) {
+        if (listAll) {
             propKeys = g.schema().getPropertyKeys();
         } else {
             propKeys = new ArrayList<>(names.size());

diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/schema/VertexLabelAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/schema/VertexLabelAPI.java
@@ -111,15 +111,16 @@ public String update(@Context GraphManager manager,
     public String list(@Context GraphManager manager,
                        @PathParam("graph") String graph,
                        @QueryParam("names") List<String> names) {
-        if (CollectionUtils.isEmpty(names)) {
+        boolean listAll = CollectionUtils.isEmpty(names);
+        if (listAll) {
             LOG.debug("Graph [{}] list vertex labels", graph);
         } else {
             LOG.debug("Graph [{}] get vertex labels by names {}", graph, names);
         }
 
         HugeGraph g = graph(manager, graph);
         List<VertexLabel> labels;
-        if (CollectionUtils.isEmpty(names)) {
+        if (listAll) {
             labels = g.schema().getVertexLabels();
         } else {
             labels = new ArrayList<>(names.size());