-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: base-ref/head-ref missed in dependency-check-ci on branch push #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
============================================
+ Coverage 62.42% 62.47% +0.05%
- Complexity 895 1868 +973
============================================
Files 91 260 +169
Lines 4404 9436 +5032
Branches 519 876 +357
============================================
+ Hits 2749 5895 +3146
- Misses 1450 3157 +1707
- Partials 205 384 +179 see 169 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
reviewed
Sep 12, 2023
imbajin
approved these changes
Sep 15, 2023
javeme
approved these changes
Sep 15, 2023
LGTM |
javeme
changed the title
fix: base-ref/head-ref missed in dependency-review on master
fix: base-ref/head-ref missed in dependency-check-ci on branch push
Sep 15, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
same with server apache/incubator-hugegraph#2308
fix: base-ref/head-ref miss in dependency-review on pushing to master
When pushing to the master branch, base-ref/head-ref isn't auto-assigned, leading to frequent errors. The reason for omitting it is that during PRs, we can directly check for unauthorized third-party libraries using 'Dependency Review' and decide whether to include them. There's no need to showcase this during master branch pushes.
Doc link 👇
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need