Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base-ref/head-ref missed in dependency-check-ci on branch push #516

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

msgui
Copy link
Contributor

@msgui msgui commented Sep 11, 2023

Purpose of the PR

same with server apache/incubator-hugegraph#2308

fix: base-ref/head-ref miss in dependency-review on pushing to master

When pushing to the master branch, base-ref/head-ref isn't auto-assigned, leading to frequent errors. The reason for omitting it is that during PRs, we can directly check for unauthorized third-party libraries using 'Dependency Review' and decide whether to include them. There's no need to showcase this during master branch pushes.
image
1694346099572

Doc link 👇
image

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Purpose of the PR

  • close #xxx

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #516 (fee25d5) into master (0008075) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #516      +/-   ##
============================================
+ Coverage     62.42%   62.47%   +0.05%     
- Complexity      895     1868     +973     
============================================
  Files            91      260     +169     
  Lines          4404     9436    +5032     
  Branches        519      876     +357     
============================================
+ Hits           2749     5895    +3146     
- Misses         1450     3157    +1707     
- Partials        205      384     +179     

see 169 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@javeme
Copy link
Contributor

javeme commented Sep 15, 2023

LGTM

@javeme javeme merged commit 0aadaa3 into apache:master Sep 15, 2023
14 checks passed
@javeme javeme changed the title fix: base-ref/head-ref missed in dependency-review on master fix: base-ref/head-ref missed in dependency-check-ci on branch push Sep 15, 2023
@liuxiaocs7
Copy link
Member

Hi, @msgui and @imbajin, similar problems have appeared in the last two commits in master, we need to address and revert some changes?

image

@imbajin
Copy link
Member

imbajin commented Dec 6, 2023

Hi, @msgui and @imbajin, similar problems have appeared in the last two commits in master, we need to address and revert some changes?

image

yes,I also noted it yesterday,just revert it in next PR maybe(its not a big problem😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants