refact: clean extra store file in all modules #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: we need use a better way to download it when building binary package
imbajin
added
dependencies
26 tasks
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
============================================
+ Coverage 62.55% 62.57% +0.01%
- Complexity 1866 1867 +1
============================================
Files 260 260
Lines 9412 9418 +6
Branches 872 872
============================================
+ Hits 5888 5893 +5
- Misses 3142 3143 +1
Partials 382 382
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Mar 6, 2023
hugegraph-client/src/main/java/org/apache/hugegraph/util/CommonUtil.java
Outdated
Show resolved
Hide resolved
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/FileLoadTest.java
Outdated
Show resolved
Hide resolved
imbajin
changed the title
javeme
previously approved these changes
Mar 17, 2023
|
Download one file failed, need check it
Update: fixed it |
zyxxoo
approved these changes
Mar 24, 2023
javeme
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
keystoreorlicense.jsonis no longer needed @javeme@simon824 download the file in building or let user download it manually when they need
https? (and we add a doc/link for it)