fix checkstyle and enable checkstyle plugin #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
============================================
- Coverage 72.72% 72.71% -0.02%
Complexity 1849 1849
============================================
Files 242 242
Lines 8104 8106 +2
Branches 717 717
============================================
Hits 5894 5894
- Misses 1827 1829 +2
Partials 383 383
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
coderzc
previously approved these changes
Aug 30, 2022
javeme
reviewed
Aug 30, 2022
hugegraph-tools/src/main/java/com/baidu/hugegraph/cmd/SubCommands.java
Outdated
Show resolved
Hide resolved
hugegraph-tools/src/main/java/com/baidu/hugegraph/formatter/kgdumper/DumpKGFormatter.java
Show resolved
Hide resolved
hugegraph-tools/src/main/java/com/baidu/hugegraph/cmd/SubCommands.java
Outdated
Show resolved
Hide resolved
hugegraph-tools/src/main/java/com/baidu/hugegraph/formatter/kgdumper/SignFS64.java
Outdated
Show resolved
Hide resolved
simon824
commented
Aug 31, 2022
| @@ -2,86 +2,216 @@ | |||
| <!DOCTYPE module PUBLIC | |||
There was a problem hiding this comment.
This file copy from https://github.com/apache/incubator-hugegraph/blob/master/style/checkstyle.xml , to keep consistent with hg server
|
hi @imbajin, please take a look at this pr when free ,thanks. |
imbajin
reviewed
Sep 20, 2022
Comment on lines
+59
to
+74
| Vertex theMatrix = graph.addVertex(T.LABEL, | ||
| "movie", "title", "The Matrix", "released", 1999); | ||
| Vertex keanu = graph.addVertex(T.LABEL, | ||
| "person", "name", "keanu Reeves", "born", 1964); | ||
| Vertex carrie = graph.addVertex(T.LABEL, | ||
| "person", "name", "carrie-anne Moss", "born", 1967); | ||
| Vertex laurence = graph.addVertex(T.LABEL, | ||
| "person", "name", "laurence Fishburne", "born", 1961); | ||
| Vertex hugo = graph.addVertex(T.LABEL, | ||
| "person", "name", "hugo Weaving", "born", 1960); | ||
| Vertex lillyW = graph.addVertex(T.LABEL, | ||
| "person", "name", "Lilly Wachowski", "born", 1967); | ||
| Vertex lanaW = graph.addVertex(T.LABEL, | ||
| "person", "name", "Lana Wachowski", "born", 1965); | ||
| Vertex joelS = graph.addVertex(T.LABEL, | ||
| "person", "name", "Joel Silver", "born", 1952); |
There was a problem hiding this comment.
seems no need to wrap new line in 59~74
There was a problem hiding this comment.
LineLength longer than 100 here
Comment on lines
+87
to
+89
| Vertex theMatrixReloaded = graph.addVertex(T.LABEL, | ||
| "movie", "title", | ||
| "The Matrix Reloaded", "released", 2003); |
There was a problem hiding this comment.
Is it a rule? Seems a little strange?
javeme
approved these changes
Oct 1, 2022
imbajin
approved these changes
Oct 8, 2022
coderzc
reviewed
Nov 23, 2022
Comment on lines
+24
to
+25
| public static final String ID = "id"; | ||
| public static final String LABEL = "label"; |
There was a problem hiding this comment.
maybe to adapt code style for the const var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #330