Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CodeQL error #288

Merged
merged 7 commits into from
May 26, 2022
Merged

fix CodeQL error #288

merged 7 commits into from
May 26, 2022

Conversation

simon824
Copy link
Member

No description provided.

@simon824 simon824 marked this pull request as draft May 26, 2022 01:44
@codecov
Copy link

codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #288 (de909f5) into master (ce8a195) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #288   +/-   ##
=========================================
  Coverage     75.70%   75.70%           
  Complexity     1849     1849           
=========================================
  Files           237      237           
  Lines          7782     7782           
  Branches        685      685           
=========================================
  Hits           5891     5891           
  Misses         1508     1508           
  Partials        383      383

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8a195...de909f5. Read the comment docs.

@simon824 simon824 marked this pull request as ready for review May 26, 2022 03:44
simon824
simon824 commented May 26, 2022
View reviewed changes
.github/workflows/codeql-analysis.yml
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- if: matrix.language == 'python' || matrix.language == 'javascript'
name: Autobuild
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages#adding-build-steps-for-a-compiled-language

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

@javeme javeme merged commit f6e6a74 into apache:master May 26, 2022
@javeme javeme added the ci Continuous integration label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@javeme javeme javeme approved these changes

Assignees
No one assigned
Labels
ci Continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon824 @javeme @imbajin