reform loader to adapt hugegraph-computer input #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
force-pushed
the
computer_adaptive
branch
from
9e9c794 to
7cb059b
Compare
javeme
reviewed
Dec 20, 2021
| final boolean needRemoveId = | ||
| builder instanceof VertexBuilder && | ||
| ((VertexLabel) builder.schemaLabel()) | ||
| .idStrategy().isPrimaryKey(); |
There was a problem hiding this comment.
can move to line 85, and improve the alignment
coderzc
force-pushed
the
computer_adaptive
branch
2 times, most recently
from
2cbc503 to
314d8aa
Compare
coderzc
force-pushed
the
computer_adaptive
branch
from
314d8aa to
6bd8a36
Compare
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
============================================
- Coverage 74.17% 73.56% -0.61%
- Complexity 873 876 +3
============================================
Files 80 81 +1
Lines 3648 3685 +37
Branches 436 439 +3
============================================
+ Hits 2706 2711 +5
- Misses 743 775 +32
Partials 199 199
Continue to review full report at Codecov.
|
javeme
approved these changes
Dec 20, 2021
corgiboygsj
approved these changes
Dec 20, 2021
javeme
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.