fix part of edge id related tests

apache · Oct 1, 2024 · 6cc46a8 · 6cc46a8
1 parent 1e00082
commit 6cc46a8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/client-ci.yml b/.github/workflows/client-ci.yml
@@ -68,7 +68,7 @@ jobs:
           cd hugegraph-client && ls *
           mvn test -Dtest=UnitTestSuite -ntp || true
           mvn test -Dtest=ApiTestSuite || true
-          mvn test -Dtest=FuncTestSuite || true
+          mvn test -Dtest=FuncTestSuite
 
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3

diff --git a/hugegraph-client/src/main/java/org/apache/hugegraph/structure/graph/Edge.java b/hugegraph-client/src/main/java/org/apache/hugegraph/structure/graph/Edge.java
@@ -142,9 +142,10 @@ public void targetLabel(String targetLabel) {
     public String name() {
         if (this.name == null) {
             String[] idParts = SplicingIdGenerator.split(this.id);
-            E.checkState(idParts.length == 4,
-                         "The edge id must be formatted by 4 parts, " +
+            E.checkState(idParts.length == 5 || idParts.length == 6,
+                         "The edge id must be formatted by 5~6 parts, " +
                          "actual is %s", idParts.length);
+            // TODO(Thespica): how to get the name of the edge?
             this.name = idParts[2];
         }
         return this.name;

diff --git a/hugegraph-client/src/test/java/org/apache/hugegraph/api/EdgeApiTest.java b/hugegraph-client/src/test/java/org/apache/hugegraph/api/EdgeApiTest.java
@@ -670,7 +670,7 @@ public void testGetNotExist() {
             // TODO: id to be modified
             edgeAPI.get(edgeId);
         }, e -> {
-            Assert.assertContains("Edge id must be formatted as 4~5 parts, " +
+            Assert.assertContains("Edge id must be formatted as 5~6 parts, " +
                                   "but got 1 parts: 'not-exist-edge-id'",
                                   e.getMessage());
             Assert.assertInstanceOf(ServerException.class, e);