feat(client): Implement new api & optimize code structure #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v3 support This commit introduces significant updates to the hugegraph-python-client module, focusing on GraphSpace compatibility and API v3 support. Key changes include: - Unified connection configuration via HGraphConfig to streamline parameter management. - Enhanced HGraphSession for unified HTTP calls with optimized URL handling. - Automatic GraphSpace detection based on server API version, ensuring compatibility with both old and new server versions. - Refactored HGraphContext and HGraphRouter for more structured URL definitions using a decorator approach. - Introduction of the @http decorator for simplified HTTP method and path definitions. - Extensive compatibility testing to ensure a seamless experience across different server versions. The update aims to provide a robust and flexible client module for interacting with HugeGraph servers, catering to the needs of both new and existing API versions.
TODO: replace it in the LLM module later
dosubot
bot
added
the
size:XXL
imbajin
reviewed
Aug 13, 2024
| @@ -46,7 +48,7 @@ class CustomConsoleHandler(logging.StreamHandler): | |||
| "INFO": "\033[0;32m", # Green | |||
| "WARNING": "\033[0;33m", # Yellow | |||
| "ERROR": "\033[0;31m", # Red | |||
| "CRITICAL": "\033[0;41m" # Red background | |||
| "CRITICAL": "\033[0;41m", # Red background | |||
There was a problem hiding this comment.
black-formatter
There was a problem hiding this comment.
black-formatter
OK, just keep it
hugegraph-python-client/README.md
Outdated
| @@ -17,7 +17,7 @@ release soon | |||
| ```python | |||
| from pyhugegraph.client import PyHugeClient | |||
|
|
|||
| client = PyHugeClient("127.0.0.1", "8080", user="admin", pwd="admin", graph="hugegraph") | |||
| client = PyHugeClient("127.0.0.1", "8080", user="admin", pwd="admin", graph="hugegraph", gs="DEFAULT") | |||
There was a problem hiding this comment.
- add a comment for this line (like
gsis optional) - currently
gscompatible withgraphspace? (set as alias)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced Naming Convention Support: Introduced support for underscore-named function calls in addition to existing camelCase naming convention. This allows for greater flexibility and compatibility with different coding styles and external libraries.
Expanded index_label Types: Augmented the index_label functionality by adding support for shard and unique types. These additional types provide enhanced indexing capabilities that enable more sophisticated data organization and retrieval scenarios, improving overall performance and scalability.
New Rank API Implementation: Implemented a new rank API to support ranking and sorting of data based on specified criteria. This feature enables applications to easily incorporate ranking logic into their workflows, enhancing user experience by presenting the most relevant or prioritized information first.
Optimized HTTP Invocation and Response Handling: Refactored HTTP client invocations to utilize a more streamlined approach. Introduced ResponseValidation for managing response checks, effectively reducing the need for explicit check_if_success calls in multiple locations. This optimization not only simplifies code but also enhances its maintainability and readability, making it easier to identify and resolve potential issues related to HTTP response handling.
TODO: