Switch to using external pex skylark rules #1114
Conversation
| "pex_pytest", | ||
| ) | ||
| load( | ||
| "@bazel_tools//tools/build_defs/pkg:pkg.bzl", |
There was a problem hiding this comment.
Is @bazel_tools defined globally somewhere and is this the proper way to reference the pkg targets we need? I see where @io_bazel_rules_pex is defined, but not @bazel_tools.
There was a problem hiding this comment.
I believe @bazel_tools is defined internally by Bazel; it replaces the former implicit merging of //tools into the user workspace.
There was a problem hiding this comment.
with 0.3.0 @bazel_tools is not supported I believe. Our repo can compile both in bazel 0.2.3 and bazel 0.3.0. Can you please ensure that it compiles with bazel 0.3.0 as well?
There was a problem hiding this comment.
I'm doing all my development and testing on 0.3.0 so far. @bazel_tools does work there.
There was a problem hiding this comment.
Cool - travis ci works with bazel 0.2.3
|
@benley - any updates on this? |
|
Sorry for disappearing; I haven't had time to work on this in the past week, but I intend to get back to it fairly soon. |
|
hi @benley, any update on this PR? |
|
Not much news, but I think I know of a reasonably sane way of publishing a usable source archive via pypi for the pex rules, which should remove the main obstacle. I'll try to make progress on this issue this week. |
|
@benley - any progress on this? |
|
@benley - wondering if you would like to merge these rules into Bazel? |
|
Hi there, sorry I have gone silent for so long. I changed jobs and have not had much time to work on bazel-related things recently. It would be cool to get the pex rules hosted under the bazelbuild project, but I don't think they will be interested because it more or less duplicates the functionality of https://github.com/google/subpar, along with bazel's built-in Python rules. I did work out a way of hosting skylark rules on pypi, though! https://pypi.python.org/pypi/bazel-rules-pex |
|
Thanks @benley - we could take care of maintaining the rules. The only issue that I am facing with it - when I run it the first time I get some errors. However, if we run bazel again, it seems to work. Not sure what is the issue - if you could help, it will be great. |
Fixes #1032
Hopefully this doesn't break compatibility with Bazel 0.2.3