-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch #4872
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
2 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
2 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
41b6156
to
b1c1b56
Compare
Run Gluten Clickhouse CI |
b1c1b56
to
3c8c34f
Compare
Run Gluten Clickhouse CI |
2 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
…d stage partial retry casuing result mismatch
This reverts commit e412421.
7aeee39
to
f667307
Compare
Run Gluten Clickhouse CI |
@marin-ma plz help review again, there is a ci pre-check failure due to network problem. |
...park33/src/test/scala/org/apache/spark/sql/execution/GlutenReplaceHashWithSortAggSuite.scala
Show resolved
Hide resolved
...park34/src/test/scala/org/apache/spark/sql/execution/GlutenReplaceHashWithSortAggSuite.scala
Show resolved
Hide resolved
LGTM. Please document the sql query modification in the code and I will proceed with merging. Thanks! |
Run Gluten Clickhouse CI |
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala
Outdated
Show resolved
Hide resolved
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
…d stage partial retry casuing result mismatch (apache#4872)
…d stage partial retry casuing result mismatch (apache#4872)
…d stage partial retry casuing result mismatch (apache#4872)
…d stage partial retry casuing result mismatch (apache#4872)
What changes were proposed in this pull request?
Spark introduced
spark.sql.execution.sortBeforeRepartition
config in https://issues.apache.org/jira/browse/SPARK-23207 to keep the result correct, and we should do the same thing in gluten plan to achieve the same affact.(Fixes: #4875)
How was this patch tested?