(VL) bugfix for query benchmark and test for orc/decimal reader #1613
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
zuochunwei
force-pushed
the
orcDecimal
branch
2 times, most recently
from
8b56897 to
649d800
Compare
zuochunwei
changed the title
| @@ -0,0 +1,61 @@ | |||
| { | |||
| "relations": [ | |||
There was a problem hiding this comment.
We may upgrade substrait, it is not recommended to save plan json file here, please save it in your local or generate as https://github.com/oap-project/gluten/blob/main/docs/developers/MicroBenchmarks.md#try-the-example
There was a problem hiding this comment.
because don't add the plan json file can't pass the ci, so I keep this file, I will merge select_decimal.json into select.json in the next orc related PR.
There was a problem hiding this comment.
Talked with @zuochunwei offline, the two json files are considered to be merged into one next. To replace, Scala unit test can also be used to test file scan.
zuochunwei
force-pushed
the
orcDecimal
branch
2 times, most recently
from
a94c09e to
914f7da
Compare
What changes were proposed in this pull request?
the corresponding velox pr is oap-project/velox#254
fix the query bench mark crash
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)