[GLUTEN-1434] [VL] Remove unused arrow code and add GLUTEN_CHECK and GLUTEN_DCHECK #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchengchenghh
force-pushed
the
plan
branch
4 times, most recently
from
0a88d40 to
cf7f5dc
Compare
| @@ -34,6 +34,7 @@ | |||
| #include "utils/compression.h" | |||
| #include "utils/macros.h" | |||
|
|
|||
| using namespace arrow; | |||
There was a problem hiding this comment.
Why this becomes required here?
There was a problem hiding this comment.
This file uses many arrow classes? Why not using namespace arrow to make code clean? I'm not sure when we could add using namepsace.
After all, this file will be deleted after I implement VeloxShuffleWriter.
There was a problem hiding this comment.
I am fine to adding this but I didn't see corresponding changes to remove the arrow:: usages in this file. So I guess this line is not actually needed or was accidently added?
zhztheplayer
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.