Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CH] Enable update clickhouse version in a config file #1634

Closed
lwz9103 opened this issue May 15, 2023 · 0 comments · Fixed by #1635
Closed

[CH] Enable update clickhouse version in a config file #1634

lwz9103 opened this issue May 15, 2023 · 0 comments · Fixed by #1635
Labels
enhancement New feature or request

Comments

@lwz9103
Copy link
Contributor

lwz9103 commented May 15, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps developers understand the context and why for this feature, in addition to the what)

Currently, clickhouse backend version is hard code in CmakeLists.txt. It's not easy to auto update.

Describe the solution you'd like
Config clickhouse backend version in a small file.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@lwz9103 lwz9103 added the enhancement New feature or request label May 15, 2023
@github-actions github-actions bot mentioned this issue May 15, 2023
Merged
liuneng1994 pushed a commit that referenced this issue May 16, 2023
@lwz9103
[GLUTEN-1634][CH] enable update clickhouse version with config file (#…
2b4cfcc 
…1635)

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)

(Fixes: #1634)

How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GLUTEN-1634][CH] enable update clickhouse version with config file lwz9103/gluten
1 participant
@lwz9103