-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG FIX: #3420 #3427
BUG FIX: #3420 #3427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3427 +/- ##
============================================
+ Coverage 63.89% 63.96% +0.06%
Complexity 71 71
============================================
Files 662 662
Lines 28535 28569 +34
Branches 4758 4784 +26
============================================
+ Hits 18233 18274 +41
+ Misses 8092 8083 -9
- Partials 2210 2212 +2
Continue to review full report at Codecov.
|
I think your pr may have some problems. You don’t have to delete all the content of the origin file and then add all content including your fix to the file. |
@tswstarplanet It's just something like \n -> \r\n. open "Diff Settings" and check "Hide whitespace changes", you will see actual changes. I'll be careful next time. |
Hi @yiding-he nice work, but please make sure you have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is difficult to review. Please only keep the minimal change. Why do you change all the lines?
IOUtils.write(InputStream, OutputStream, int)
BUG DO NOT USE org.apache.dubbo.common.utils.IOUtils.write() for your own project #3420IOUtils.write(Reader, Writer, int)
not usingbufferSize
parameter.org.apache.dubbo.common.io.Bytes#unzip()
is now using fixedwrite()
method so it is worth running aBytesTest#testZip()
test.