Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: #3420 #3427

Closed
wants to merge 1 commit into from
Closed

BUG FIX: #3420 #3427

wants to merge 1 commit into from

Conversation

yiding-he
Copy link

@yiding-he yiding-he commented Feb 2, 2019

  1. IOUtils.write(InputStream, OutputStream, int) BUG DO NOT USE org.apache.dubbo.common.utils.IOUtils.write() for your own project #3420
  2. IOUtils.write(Reader, Writer, int) not using bufferSize parameter.

org.apache.dubbo.common.io.Bytes#unzip() is now using fixed write() method so it is worth running a BytesTest#testZip() test.

1. IOUtils.write(InputStream, OutputStream, int) BUG#3420;
2. IOUtils.write(Reader, Writer, int) not using `bufferSize` parameter.
@codecov-io
Copy link

Codecov Report

Merging #3427 into master will increase coverage by 0.06%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3427      +/-   ##
============================================
+ Coverage     63.89%   63.96%   +0.06%     
  Complexity       71       71              
============================================
  Files           662      662              
  Lines         28535    28569      +34     
  Branches       4758     4784      +26     
============================================
+ Hits          18233    18274      +41     
+ Misses         8092     8083       -9     
- Partials       2210     2212       +2
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/common/utils/IOUtils.java 88.88% <88.88%> (-0.25%) 0 <0> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0%> (-3.85%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...ting/exchange/support/header/HeartbeatHandler.java 84.44% <0%> (-1.92%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 68.42% <0%> (-1.23%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyClient.java 74.6% <0%> (-1.21%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyClient.java 66.1% <0%> (-1.14%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 58.46% <0%> (-0.92%) 0% <0%> (ø)
.../main/java/org/apache/dubbo/qos/textui/TTable.java 83.79% <0%> (-0.87%) 0% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c9de9...219e1c7. Read the comment docs.

@tswstarplanet
Copy link
Contributor

tswstarplanet commented Feb 2, 2019

I think your pr may have some problems. You don’t have to delete all the content of the origin file and then add all content including your fix to the file.
Please check your pr and resubmit it.

@yiding-he
Copy link
Author

yiding-he commented Feb 2, 2019

@tswstarplanet It's just something like \n -> \r\n. open "Diff Settings" and check "Hide whitespace changes", you will see actual changes. I'll be careful next time.

@kun-song
Copy link
Contributor

kun-song commented Feb 3, 2019

Hi @yiding-he nice work, but please make sure you have autocrlf = false in your git configuration since we don't use \n\r for a newline, thanks :)

@LiZhenNet LiZhenNet mentioned this pull request Feb 25, 2019
6 tasks
Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is difficult to review. Please only keep the minimal change. Why do you change all the lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants