Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IOUtils.write bug #3559

Closed
wants to merge 1 commit into from
Closed

Fix IOUtils.write bug #3559

wants to merge 1 commit into from

Conversation

LiZhenNet
Copy link
Contributor

What is the purpose of the change

Fix #3420

Brief changelog

use EOF to make sure stream reaches end

Verifying this change

UT

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3559 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3559      +/-   ##
============================================
- Coverage     64.16%   64.12%   -0.05%     
  Complexity       71       71              
============================================
  Files           664      664              
  Lines         28629    28627       -2     
  Branches       4771     4770       -1     
============================================
- Hits          18371    18358      -13     
- Misses         8034     8042       +8     
- Partials       2224     2227       +3
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/common/utils/IOUtils.java 88.63% <100%> (-0.5%) 0 <0> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 55.81% <0%> (-2.33%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.7% <0%> (-0.79%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 57.14% <0%> (+0.37%) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 72.97% <0%> (+0.67%) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a98f3...6589112. Read the comment docs.

@LiZhenNet
Copy link
Contributor Author

Duplicate: #3427, closed

@LiZhenNet LiZhenNet closed this Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DO NOT USE org.apache.dubbo.common.utils.IOUtils.write() for your own project
3 participants