feat: Generic webhook #8057
Draft
feat: Generic webhook #8057
+123
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
|
Nice work! |
|
Anybody that could have a look at this and help me out ? |
d4x1
reviewed
Oct 15, 2024
| type WebhookGenericReq struct { | ||
| Title string `mapstructure:"title" validate:"required"` | ||
| Description string `mapstructure:"description"` | ||
| Data map[string]interface{} `mapstructure:"json"` |
There was a problem hiding this comment.
I think the mapstructure tag value should be data. Is it a typo?
|
|
||
| err = api.DecodeMapStruct(input.Body, request, true) | ||
| if err != nil { | ||
| return &plugin.ApiResourceOutput{Body: err.Error(), Status: http.StatusBadRequest}, nil |
There was a problem hiding this comment.
You can just return err as the second returned value.
| generic.Title = request.Title | ||
| generic.Description = request.Description | ||
| generic.CreatedDate = request.CreatedDate | ||
| generic.Data = fmt.Sprintf("%s", request.Data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
This PR tries to implement #7765 by adding a generic webhook to push any generic/custom data into the database.
Currently WIP, I am struggling to correctly save the information to database looking for feedback to make the code better.
Does this close any open issues?
#7765
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.