Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added supported sources section for all pages and updated introduction doc #592

Merged
merged 11 commits into from
Jul 26, 2023
Merged

added supported sources section for all pages and updated introduction doc #592

merged 11 commits into from
Jul 26, 2023

Conversation

JoshuaPoddoku
Copy link
Contributor

@JoshuaPoddoku JoshuaPoddoku commented Jul 19, 2023 •
edited
Loading

⚠️   Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have npm run build and npm run serve locally before submitting this PR
  • I have read through the Contributing Documentation

Summary

Does this close any open issues?

Closes #580

@JoshuaPoddoku JoshuaPoddoku mentioned this pull request Jul 19, 2023
Closed
2 tasks
Startrekzky
Startrekzky requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be more careful of the wording.

docs/Plugins/bitbucket.md Outdated Show resolved Hide resolved
docs/Plugins/github.md Outdated Show resolved Hide resolved
docs/Plugins/pagerduty.md Outdated Show resolved Hide resolved
docs/Plugins/sonarqube.md Outdated Show resolved Hide resolved
docs/Plugins/zentao.md Outdated Show resolved Hide resolved
docs/Plugins/gitlab.md Outdated Show resolved Hide resolved
docs/Plugins/jenkins.md Outdated Show resolved Hide resolved
@Startrekzky
Copy link
Contributor

Hi @klesh , some valid URLs didn't pass the link checker again. Can you take a look? No rush.

Startrekzky
Startrekzky requested changes Jul 21, 2023
View reviewed changes
src/components/Sections/WhyDevlake.tsx Outdated Show resolved Hide resolved
docs/Plugins/tapd.md Outdated Show resolved Hide resolved
@klesh
Copy link
Contributor

klesh commented Jul 24, 2023

Please merge #600 first, and rebase this PR, it should be OK afterward.

@JoshuaPoddoku
Copy link
Contributor Author

@Startrekzky @klesh let me know if it worked.

@JoshuaPoddoku
Copy link
Contributor Author

@Startrekzky I've added introduction page updates to the same PR. Closes #593

@JoshuaPoddoku JoshuaPoddoku changed the title added supported sources section for all pages added supported sources section for all pages and updated introduction doc Jul 24, 2023
@JoshuaPoddoku
Copy link
Contributor Author

@Startrekzky I've updated the changes.

Startrekzky
Startrekzky approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Startrekzky Startrekzky merged commit bb4c768 into apache:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Startrekzky Startrekzky Startrekzky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc] Make 'supported data sources' information more accessible
3 participants
@JoshuaPoddoku @Startrekzky @klesh