Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-22416 Implement snapshots for zone based partitions #5212

Merged
merged 7 commits into from
Feb 14, 2025
Merged

IGNITE-22416 Implement snapshots for zone based partitions #5212

merged 7 commits into from
Feb 14, 2025

Conversation

sashapolo
Copy link
Contributor

https://issues.apache.org/jira/browse/IGNITE-22416

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@sashapolo sashapolo force-pushed the ignite-22416 branch 4 times, most recently from 6f89c82 to c05f266 Compare February 12, 2025 09:38
@sashapolo sashapolo marked this pull request as ready for review February 12, 2025 09:38
rpuch
rpuch reviewed Feb 13, 2025
View reviewed changes
...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java Show resolved Hide resolved
...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java Show resolved Hide resolved
...r/src/main/java/org/apache/ignite/internal/partition/replicator/raft/RaftTableProcessor.java Outdated Show resolved Hide resolved
...ache/ignite/internal/partition/replicator/raft/snapshot/PartitionSnapshotStorageFactory.java Show resolved Hide resolved
...ache/ignite/internal/partition/replicator/raft/snapshot/PartitionSnapshotStorageFactory.java Show resolved Hide resolved
...org/apache/ignite/internal/partition/replicator/raft/snapshot/outgoing/OutgoingSnapshot.java Outdated Show resolved Hide resolved
...ache/ignite/internal/partition/replicator/raft/snapshot/outgoing/PartitionDeliveryState.java Outdated Show resolved Hide resolved
...org/apache/ignite/internal/partition/replicator/raft/snapshot/outgoing/OutgoingSnapshot.java Outdated Show resolved Hide resolved
...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Show resolved Hide resolved
...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Show resolved Hide resolved
@sashapolo sashapolo merged commit 6b91a50 into apache:main Feb 14, 2025
1 check passed
@sashapolo sashapolo deleted the ignite-22416 branch February 14, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpuch rpuch rpuch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashapolo @rpuch