IGNITE-23920 Shutdown node on SIGTERM #5010
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valepakh
reviewed
Jan 9, 2025
| AtomicBoolean shutdown = new AtomicBoolean(false); | ||
| Runtime.getRuntime().addShutdownHook(new Thread(() -> { | ||
| try { | ||
| LOG.info("Ignite node shutting down..."); |
There was a problem hiding this comment.
While testing this, I've found that logging via the framework is unreliable, looks like it could already be shut down. I'd use System.out and System.err directly instead of the logger.
There was a problem hiding this comment.
Also should we try to use jdk.internal.misc.Signal#handle instead of the shutdown hook? The order of hooks execution is not defined and Micronaut also registers a hook so it's impossible to do a really clean shutdown when only the IgniteServer.shutdown is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23920