Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-23634 Make hardcoded REBALANCE_RETRY_DELAY_MS configurable #4951

Merged
merged 9 commits into from
Dec 24, 2024

Conversation

kgusakov
Copy link
Contributor

@kgusakov kgusakov marked this pull request as ready for review December 23, 2024 20:47
@kgusakov kgusakov changed the title IGNITGE-23634 Make hardcoded REBALANCE_RETRY_DELAY_MS configurable IGNITE-23634 Make hardcoded REBALANCE_RETRY_DELAY_MS configurable Dec 23, 2024
@@ -82,6 +88,21 @@ void testHaRecoveryOfTwoZones() throws InterruptedException {
waitAndAssertStableAssignmentsOfPartitionEqualTo(node, table22, PARTITION_IDS, Set.of(node.name()));
}

@Test
void testInvaliPartitionResetTimeoutUpdate() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

/**
* Init property value, but doesn't call the listener.
*/
public void init() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a bit more details why we need this init and when it must be called

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@sanpwc sanpwc merged commit 02af2a9 into apache:main Dec 24, 2024
1 check passed
@sanpwc sanpwc deleted the ignite-23634 branch December 24, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants